third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp - Issue 1463473002: Make unicode-bidi:isolate the default for elements with dir attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 1463473002: Make unicode-bidi:isolate the default for elements with dir attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: leviw review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('k') | third_party/WebKit/Source/core/html/HTMLElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

index 29125bddb0493eedf2210e5671ec6adcbb100f47..0a0cb671bf83ed94b6beb38837069d799130e3b3 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

@@ -634,7 +634,7 @@ static bool executeJustifyRight(LocalFrame& frame, Event*, EditorCommandSource s

static bool executeMakeTextWritingDirectionLeftToRight(LocalFrame& frame, Event*, EditorCommandSource, const String&)

{

RefPtrWillBeRawPtr<MutableStylePropertySet> style = MutableStylePropertySet::create(HTMLQuirksMode);

- style->setProperty(CSSPropertyUnicodeBidi, CSSValueEmbed);

+ style->setProperty(CSSPropertyUnicodeBidi, CSSValueIsolate);

style->setProperty(CSSPropertyDirection, CSSValueLtr);

frame.editor().applyStyle(style.get(), EditActionSetWritingDirection);

return true;

@@ -651,7 +651,7 @@ static bool executeMakeTextWritingDirectionNatural(LocalFrame& frame, Event*, Ed

static bool executeMakeTextWritingDirectionRightToLeft(LocalFrame& frame, Event*, EditorCommandSource, const String&)

{

RefPtrWillBeRawPtr<MutableStylePropertySet> style = MutableStylePropertySet::create(HTMLQuirksMode);

- style->setProperty(CSSPropertyUnicodeBidi, CSSValueEmbed);

+ style->setProperty(CSSPropertyUnicodeBidi, CSSValueIsolate);

style->setProperty(CSSPropertyDirection, CSSValueRtl);

frame.editor().applyStyle(style.get(), EditActionSetWritingDirection);

return true;