third_party/WebKit/LayoutTests/fast/css/default-bidi-css-rules.html - Issue 1463473002: Make unicode-bidi:isolate the default for elements with dir attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css/default-bidi-css-rules.html

Issue 1463473002: Make unicode-bidi:isolate the default for elements with dir attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: leviw review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/style/script-tests/make-text-writing-direction-inline-win.js ('k') | third_party/WebKit/LayoutTests/fast/css/default-bidi-css-rules-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css/default-bidi-css-rules.html

diff --git a/third_party/WebKit/LayoutTests/fast/css/default-bidi-css-rules.html b/third_party/WebKit/LayoutTests/fast/css/default-bidi-css-rules.html

index 9d8ce0a7684d1569ecc731a0b5015a78bf4708d8..a78b14bb22c40a379b8b289a7587940a9c3defe2 100644

--- a/third_party/WebKit/LayoutTests/fast/css/default-bidi-css-rules.html

+++ b/third_party/WebKit/LayoutTests/fast/css/default-bidi-css-rules.html

@@ -21,16 +21,16 @@ function styleOf(name, attributes) {

var tests = [

['div', {}, 'ltr', '-webkit-isolate'],

- ['div', {'dir': 'ltr'}, 'ltr', 'embed'],

- ['div', {'dir': 'rtl'}, 'rtl', 'embed'],

+ ['div', {'dir': 'ltr'}, 'ltr', 'isolate'],

+ ['div', {'dir': 'rtl'}, 'rtl', 'isolate'],

['div', {'dir': 'auto'}, 'ltr', 'isolate'],

- ['div', {'dir': ''}, 'ltr', 'embed'],

+ ['div', {'dir': ''}, 'ltr', 'isolate'],

['span', {}, 'ltr', 'normal'],

- ['span', {'dir': 'ltr'}, 'ltr', 'embed'],

- ['span', {'dir': 'rtl'}, 'rtl', 'embed'],

+ ['span', {'dir': 'ltr'}, 'ltr', 'isolate'],

+ ['span', {'dir': 'rtl'}, 'rtl', 'isolate'],

['span', {'dir': 'auto'}, 'ltr', 'isolate'],

- ['span', {'dir': ''}, 'ltr', 'embed'],

+ ['span', {'dir': ''}, 'ltr', 'isolate'],

['bdi', {}, 'ltr', 'isolate'],

['bdi', {'dir': 'ltr'}, 'ltr', 'isolate'],

@@ -51,16 +51,16 @@ var tests = [

['bdo', {'dir': ''}, 'ltr', 'bidi-override'],

['textarea', {}, 'ltr', 'normal'],

- ['textarea', {'dir': 'ltr'}, 'ltr', 'embed'],

- ['textarea', {'dir': 'rtl'}, 'rtl', 'embed'],

+ ['textarea', {'dir': 'ltr'}, 'ltr', 'isolate'],

+ ['textarea', {'dir': 'rtl'}, 'rtl', 'isolate'],

['textarea', {'dir': 'auto'}, 'ltr', 'plaintext'],

- ['textarea', {'dir': ''}, 'ltr', 'embed'],

+ ['textarea', {'dir': ''}, 'ltr', 'isolate'],

['pre', {}, 'ltr', 'normal'],

- ['pre', {'dir': 'ltr'}, 'ltr', 'embed'],

- ['pre', {'dir': 'rtl'}, 'rtl', 'embed'],

+ ['pre', {'dir': 'ltr'}, 'ltr', 'isolate'],

+ ['pre', {'dir': 'rtl'}, 'rtl', 'isolate'],

['pre', {'dir': 'auto'}, 'ltr', 'plaintext'],

- ['pre', {'dir': ''}, 'ltr', 'embed'],

+ ['pre', {'dir': ''}, 'ltr', 'isolate'],

].forEach(function (test) {

shouldBe('styleOf("' + test[0] + '", ' + JSON.stringify(test[1]) + ').direction', '"' + test[2] + '"');

container.innerHTML = '';