Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: content/browser/appcache/appcache_update_job.h

Issue 1463463003: AppCache: fix a browser crashing bug that can happen during updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/appcache/appcache_update_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_UPDATE_JOB_H_ 5 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_UPDATE_JOB_H_
6 #define CONTENT_BROWSER_APPCACHE_APPCACHE_UPDATE_JOB_H_ 6 #define CONTENT_BROWSER_APPCACHE_APPCACHE_UPDATE_JOB_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 276
277 AppCacheGroup* group_; 277 AppCacheGroup* group_;
278 278
279 UpdateType update_type_; 279 UpdateType update_type_;
280 InternalUpdateState internal_state_; 280 InternalUpdateState internal_state_;
281 base::Time last_progress_time_; 281 base::Time last_progress_time_;
282 bool doing_full_update_check_; 282 bool doing_full_update_check_;
283 283
284 PendingMasters pending_master_entries_; 284 PendingMasters pending_master_entries_;
285 size_t master_entries_completed_; 285 size_t master_entries_completed_;
286 std::set<GURL> failed_master_entries_;
286 287
287 // TODO(jennb): Delete when update no longer fetches master entries directly. 288 // TODO(jennb): Delete when update no longer fetches master entries directly.
288 // Helper containers to track which pending master entries have yet to be 289 // Helper containers to track which pending master entries have yet to be
289 // fetched and which are currently being fetched. Master entries that 290 // fetched and which are currently being fetched. Master entries that
290 // are listed in the manifest may be fetched as a regular URL instead of 291 // are listed in the manifest may be fetched as a regular URL instead of
291 // as a separate master entry fetch to optimize against duplicate fetches. 292 // as a separate master entry fetch to optimize against duplicate fetches.
292 std::set<GURL> master_entries_to_fetch_; 293 std::set<GURL> master_entries_to_fetch_;
293 PendingUrlFetches master_entry_fetches_; 294 PendingUrlFetches master_entry_fetches_;
294 295
295 // URLs of files to fetch along with their flags. 296 // URLs of files to fetch along with their flags.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 base::WeakPtrFactory<AppCacheUpdateJob> weak_factory_; 341 base::WeakPtrFactory<AppCacheUpdateJob> weak_factory_;
341 342
342 FRIEND_TEST_ALL_PREFIXES(content::AppCacheGroupTest, QueueUpdate); 343 FRIEND_TEST_ALL_PREFIXES(content::AppCacheGroupTest, QueueUpdate);
343 344
344 DISALLOW_COPY_AND_ASSIGN(AppCacheUpdateJob); 345 DISALLOW_COPY_AND_ASSIGN(AppCacheUpdateJob);
345 }; 346 };
346 347
347 } // namespace content 348 } // namespace content
348 349
349 #endif // CONTENT_BROWSER_APPCACHE_APPCACHE_UPDATE_JOB_H_ 350 #endif // CONTENT_BROWSER_APPCACHE_APPCACHE_UPDATE_JOB_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/appcache/appcache_update_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698