Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1463463002: Temporarily re-add #include <algorithm> to scoped_ptr.h (Closed)

Created:
5 years, 1 month ago by dcheng
Modified:
5 years, 1 month ago
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily re-add #include <algorithm> to scoped_ptr.h In C++11, std::swap() moved to <utility>. However, lots of random source files still depend on scoped_ptr.h having #include <algorithm>. BUG=none R=kinuko@google.com TBR=danakj@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/b5c3eed8475ad778e6e7fa5a1e569ff2a3321bc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/memory/scoped_ptr.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kinuko (google)
lgtm for cross-sanity check
5 years, 1 month ago (2015-11-19 07:47:50 UTC) #4
dcheng
Doing a test build of base_unittests locally before landing. Stupid Windows bots...
5 years, 1 month ago (2015-11-19 07:49:31 UTC) #6
kinuko
Um, and let me stamp from the right address
5 years, 1 month ago (2015-11-19 07:50:11 UTC) #7
kinuko
lgtm
5 years, 1 month ago (2015-11-19 07:50:18 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b5c3eed8475ad778e6e7fa5a1e569ff2a3321bc0 Cr-Commit-Position: refs/heads/master@{#360543}
5 years, 1 month ago (2015-11-19 07:57:42 UTC) #9
dcheng
5 years, 1 month ago (2015-11-19 07:58:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5c3eed8475ad778e6e7fa5a1e569ff2a3321bc0 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698