third_party/WebKit/Source/core/dom/MutationObserverInterestGroup.h - Issue 1463433002: Use RefPtr for MutationObserver in MutationObserverInterestGroup.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/MutationObserverInterestGroup.h

Issue 1463433002: Use RefPtr for MutationObserver in MutationObserverInterestGroup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/MutationObserver/mutation-and-deletion-race-expected.txt ('k') | third_party/WebKit/Source/core/dom/MutationObserverInterestGroup.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69 return createIfNeeded(target, MutationObserver::Attributes, MutationObse rver::AttributeOldValue, &attributeName);	69 return createIfNeeded(target, MutationObserver::Attributes, MutationObse rver::AttributeOldValue, &attributeName);

70 }	70 }

71	71

72 bool isOldValueRequested();	72 bool isOldValueRequested();

73 void enqueueMutationRecord(PassRefPtrWillBeRawPtr<MutationRecord>);	73 void enqueueMutationRecord(PassRefPtrWillBeRawPtr<MutationRecord>);

74	74

75 DECLARE_TRACE();	75 DECLARE_TRACE();

76	76

77 private:	77 private:

78 static PassOwnPtrWillBeRawPtr<MutationObserverInterestGroup> createIfNeeded( Node& target, MutationObserver::MutationType, MutationRecordDeliveryOptions oldV alueFlag, const QualifiedName* attributeName = 0);	78 static PassOwnPtrWillBeRawPtr<MutationObserverInterestGroup> createIfNeeded( Node& target, MutationObserver::MutationType, MutationRecordDeliveryOptions oldV alueFlag, const QualifiedName* attributeName = 0);

79 MutationObserverInterestGroup(WillBeHeapHashMap<RawPtrWillBeMember<MutationO bserver>, MutationRecordDeliveryOptions>& observers, MutationRecordDeliveryOptio ns oldValueFlag);	79 MutationObserverInterestGroup(WillBeHeapHashMap<RefPtrWillBeMember<MutationO bserver>, MutationRecordDeliveryOptions>& observers, MutationRecordDeliveryOptio ns oldValueFlag);

80	80

81 bool hasOldValue(MutationRecordDeliveryOptions options) { return options & m _oldValueFlag; }	81 bool hasOldValue(MutationRecordDeliveryOptions options) { return options & m _oldValueFlag; }

82	82

83 WillBeHeapHashMap<RawPtrWillBeMember<MutationObserver>, MutationRecordDelive ryOptions> m_observers;	83 WillBeHeapHashMap<RefPtrWillBeMember<MutationObserver>, MutationRecordDelive ryOptions> m_observers;

84 MutationRecordDeliveryOptions m_oldValueFlag;	84 MutationRecordDeliveryOptions m_oldValueFlag;

85 };	85 };

86	86

87 }	87 }

88	88

89 #endif // MutationObserverInterestGroup_h	89 #endif // MutationObserverInterestGroup_h

OLD	NEW