Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1463393003: DevTools: Make item info follow the mouse on the flame chart. (Closed)

Created:
5 years, 1 month ago by alph
Modified:
5 years ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make item info follow the mouse on the flame chart. Add info to the network part of the timeline flamechart. BUG=528489 Committed: https://crrev.com/708e3609f90afdae12e3cbe70c245dd0409c7ba7 Cr-Commit-Position: refs/heads/master@{#361213}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comments + coloring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 1 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/flameChart.css View 1 1 chunk +27 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
alph
5 years, 1 month ago (2015-11-21 04:10:47 UTC) #2
caseq
lgtm https://codereview.chromium.org/1463393003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/1463393003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode953 third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:953: if (request.requestMethod) Let's only care for the requests ...
5 years ago (2015-11-23 18:38:12 UTC) #4
alph
https://codereview.chromium.org/1463393003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/1463393003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode953 third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:953: if (request.requestMethod) On 2015/11/23 18:38:12, caseq wrote: > Let's ...
5 years ago (2015-11-23 19:54:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463393003/20001
5 years ago (2015-11-23 19:56:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-23 23:14:44 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-23 23:15:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/708e3609f90afdae12e3cbe70c245dd0409c7ba7
Cr-Commit-Position: refs/heads/master@{#361213}

Powered by Google App Engine
This is Rietveld 408576698