scaling API on SkPixmap

scaling API on SkPixmap

BUG=skia:4481
Committed: https://skia.googlesource.com/skia/+/095530389d8211895309107a4f74beefacce638c

[reed1, 2015-11-20 21:53:26]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[f(malita), 2015-11-21 13:27:46]

lgtm

[reed1, 2015-11-22 19:28:38]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-22 19:28:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1463373002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1463373002/20001

[commit-bot: I haz the power, 2015-11-22 19:31:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-22 19:31:32]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[reed1, 2015-11-22 19:32:45]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-22 19:32:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1463373002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1463373002/40001

[reed1, 2015-11-22 19:33:01]

ptal -- now with actual impl

[reed1, 2015-11-22 19:33:41]

The CQ bit was unchecked by reed@google.com

[reed1, 2015-11-22 19:43:12]

todo:
- ensure that volatile means we don't try to cache the output
- consider taking a dont_cache enum to the image version, as we are considering
for readPixels, so we don't cache the input.

[reed1, 2015-11-23 17:50:23]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-23 17:50:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1463373002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1463373002/80001

[reed1, 2015-11-23 17:51:11]

todos done, ptal

[f(malita), 2015-11-23 17:58:50]

Description was changed from

==========
scaling API on SkPixmap

BUG=skia:
==========

to

==========
scaling API on SkPixmap

BUG=skia:4481
==========

[commit-bot: I haz the power, 2015-11-23 18:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 18:05:57]

Dry run: This issue passed the CQ dry run.

[f(malita), 2015-11-23 18:06:37]

LGTM

https://codereview.chromium.org/1463373002/diff/80001/gm/image.cpp
File gm/image.cpp (right):

https://codereview.chromium.org/1463373002/diff/80001/gm/image.cpp#newcode209
gm/image.cpp:209: //   canvas->drawImage(image, 0, 0, nullptr);
Leftover?

https://codereview.chromium.org/1463373002/diff/80001/src/image/SkImage.cpp
File src/image/SkImage.cpp (right):

https://codereview.chromium.org/1463373002/diff/80001/src/image/SkImage.cpp#n...
src/image/SkImage.cpp:61: //       this code path should take advantage of that.
Don't we already have this (SkPictureImageGenerator)?

[reed1, 2015-11-23 20:07:22]

https://codereview.chromium.org/1463373002/diff/80001/gm/image.cpp
File gm/image.cpp (right):

https://codereview.chromium.org/1463373002/diff/80001/gm/image.cpp#newcode209
gm/image.cpp:209: //   canvas->drawImage(image, 0, 0, nullptr);
On 2015/11/23 18:06:36, f(malita) wrote:
> Leftover?

Oops, yes, I will uncomment

https://codereview.chromium.org/1463373002/diff/80001/src/image/SkImage.cpp
File src/image/SkImage.cpp (right):

https://codereview.chromium.org/1463373002/diff/80001/src/image/SkImage.cpp#n...
src/image/SkImage.cpp:61: //       this code path should take advantage of that.
On 2015/11/23 18:06:37, f(malita) wrote:
> Don't we already have this (SkPictureImageGenerator)?

The ImageGenerator API doesn't support scaling yet. I'll change the comment to
that.

[reed1, 2015-11-23 20:19:02]

The CQ bit was checked by reed@google.com

[reed1, 2015-11-23 20:19:03]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1463373002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-11-23 20:19:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1463373002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1463373002/100001

[commit-bot: I haz the power, 2015-11-23 20:32:18]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/095530389d8211895309107a4f74beefacce638c