Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1463333003: Increase the maximum MDNS device limit from 64 to 2048. (Closed)

Created:
5 years, 1 month ago by Kevin M
Modified:
5 years ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase the maximum MDNS device limit from 64 to 2048. The new size should be large enough so as to not interfere with the API in the field or in testing labs, but not so large that it allows malicious persons to bog down Chrome with large forged MDNS device listings. R=leilei@chromium.org CC=mfoltz@chromium.org Committed: https://crrev.com/aff93dd52022e2ce91fb6f204589b312a5570f0d Cr-Commit-Position: refs/heads/master@{#361548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/extensions/api/mdns/mdns_api_unittest.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/mdns.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (9 generated)
Kevin M
5 years, 1 month ago (2015-11-20 22:32:18 UTC) #1
Lei Lei
lgtm
5 years, 1 month ago (2015-11-20 22:33:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463333003/1
5 years, 1 month ago (2015-11-20 22:38:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
5 years, 1 month ago (2015-11-20 22:59:07 UTC) #7
Kevin M
rockot@ for extensions/
5 years, 1 month ago (2015-11-20 23:52:24 UTC) #9
Kevin M
ping!
5 years, 1 month ago (2015-11-23 21:16:37 UTC) #10
Ken Rockot(use gerrit already)
Oops! Sorry, lgtm!
5 years, 1 month ago (2015-11-23 21:18:49 UTC) #11
Kevin M
Thankee!
5 years, 1 month ago (2015-11-23 21:25:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463333003/1
5 years, 1 month ago (2015-11-23 21:27:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133102)
5 years, 1 month ago (2015-11-23 22:57:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463333003/1
5 years, 1 month ago (2015-11-24 00:01:01 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133235)
5 years, 1 month ago (2015-11-24 03:16:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463333003/1
5 years ago (2015-11-25 01:21:19 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 03:22:50 UTC) #23
commit-bot: I haz the power
5 years ago (2015-11-25 03:24:02 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aff93dd52022e2ce91fb6f204589b312a5570f0d
Cr-Commit-Position: refs/heads/master@{#361548}

Powered by Google App Engine
This is Rietveld 408576698