Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1463303003: Fix Skia Depsroll (Closed)

Created:
5 years, 1 month ago by stephana
Modified:
5 years, 1 month ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Skia Depsroll BUG=559300 Committed: https://crrev.com/1e37d76d682ec823d16163e9129999f714f41e0b Cr-Commit-Position: refs/heads/master@{#360920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/layers/layer-canvas-log-expected.txt View 1 chunk +3 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
stephana
5 years, 1 month ago (2015-11-20 20:19:15 UTC) #3
robertphillips
lgtm
5 years, 1 month ago (2015-11-20 20:20:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463303003/1
5 years, 1 month ago (2015-11-20 20:21:27 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-20 20:21:28 UTC) #9
tfarina
lgtm
5 years, 1 month ago (2015-11-20 20:36:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463303003/1
5 years, 1 month ago (2015-11-20 20:37:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 21:36:04 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1e37d76d682ec823d16163e9129999f714f41e0b Cr-Commit-Position: refs/heads/master@{#360920}
5 years, 1 month ago (2015-11-20 21:37:36 UTC) #15
dcheng
5 years, 1 month ago (2015-11-20 23:00:47 UTC) #16
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1463923004/ by dcheng@chromium.org.

The reason for reverting is: Collided with the skia roll (which already marked
this test for rebaselining).

Powered by Google App Engine
This is Rietveld 408576698