Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1463293004: Reset server_socket_ when listen fails in extensions::TCPSocket. (Closed)

Created:
5 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset server_socket_ when listen fails in extensions::TCPSocket. net::TCPServerSocket::Listen will close its internal socket if it fails to bind and begin listening. This leaves the extensions socket object in a bad state. Instead reset the socket so that an application can try to bind it again. BUG=559368 Committed: https://crrev.com/97b9851546675bd7ccc4d1dfb48cddbf3502ca94 Cr-Commit-Position: refs/heads/master@{#361191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -2 lines) Patch
M chrome/test/data/extensions/api_test/socket/api/background.js View 3 chunks +45 lines, -1 line 0 comments Download
M extensions/browser/api/socket/tcp_socket.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 1 month ago (2015-11-20 23:22:23 UTC) #2
asargent_no_longer_on_chrome
lgtm
5 years, 1 month ago (2015-11-20 23:34:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463293004/1
5 years, 1 month ago (2015-11-20 23:38:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/144254)
5 years, 1 month ago (2015-11-21 00:36:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463293004/1
5 years, 1 month ago (2015-11-21 02:46:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/134179)
5 years, 1 month ago (2015-11-21 03:53:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463293004/1
5 years, 1 month ago (2015-11-23 19:09:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/144932)
5 years, 1 month ago (2015-11-23 20:30:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463293004/1
5 years, 1 month ago (2015-11-23 20:46:38 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 21:41:55 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 21:42:49 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97b9851546675bd7ccc4d1dfb48cddbf3502ca94
Cr-Commit-Position: refs/heads/master@{#361191}

Powered by Google App Engine
This is Rietveld 408576698