Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1463193002: MIPS64: [turbofan] Implemented the TruncateFloat64ToUint64 TurboFan operator. (Closed)

Created:
5 years, 1 month ago by akos.palfi.imgtec
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: [turbofan] Implemented the TruncateFloat64ToUint64 TurboFan operator. Port f6e689cebbd2de36e2b38474f89b1ad37fbfbb0f BUG= Committed: https://crrev.com/05f01e69c3be786eee6017b40b4fff14452da099 Cr-Commit-Position: refs/heads/master@{#32147}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 chunks +37 lines, -0 lines 1 comment Download

Depends on Patchset:

Issue 1462803003 Patch 1

Messages

Total messages: 15 (6 generated)
akos.palfi.imgtec
PTAL.
5 years, 1 month ago (2015-11-20 11:25:09 UTC) #2
balazs.kilvady
LGTM
5 years, 1 month ago (2015-11-20 12:21:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463193002/1
5 years, 1 month ago (2015-11-20 12:24:39 UTC) #6
balazs.kilvady
NOT LGTM
5 years, 1 month ago (2015-11-20 12:41:41 UTC) #8
balazs.kilvady
lgtm
5 years, 1 month ago (2015-11-20 12:47:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463193002/20001
5 years, 1 month ago (2015-11-20 12:47:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-20 13:11:09 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/05f01e69c3be786eee6017b40b4fff14452da099 Cr-Commit-Position: refs/heads/master@{#32147}
5 years, 1 month ago (2015-11-20 13:11:35 UTC) #13
Alan Li
5 years, 1 month ago (2015-11-20 13:35:22 UTC) #15
Message was sent while issue was closed. 
https://codereview.chromium.org/1463193002/diff/20001/src/mips64/macro-assemb...
File src/mips64/macro-assembler-mips64.cc (right):

https://codereview.chromium.org/1463193002/diff/20001/src/mips64/macro-assemb...
src/mips64/macro-assembler-mips64.cc:1705: Or(rs, rs, Operand(1UL << 63));
maybe splitting the Or into LI and ORI, and put ORI in the delay slot is better?

Powered by Google App Engine
This is Rietveld 408576698