Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1463173002: Fake implementation of get_interfaces. This is needed because getifaddrs fails under NaCl and the S… (Closed)

Created:
5 years, 1 month ago by zentaro
Modified:
5 years, 1 month ago
Reviewers:
bradnelson, bradn, Sam Clegg
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Fake implementation of get_interfaces. This is needed because getifaddrs fails under NaCl and the Samba library will refuse to load if it finds no network interfaces. This CL returns a fake entry. The entry is never used anyway because NBT name resolution is implemented in the javascript side to the smb library never needs to use this to broadcast NetBIOS messages. BUG= Committed: https://chromium.googlesource.com/external/naclports/+/0d807fb9ccd1d588e7b0a2ef508a736130097c10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -1 line) Patch
M ports/samba/build.sh View 1 chunk +1 line, -1 line 0 comments Download
M ports/samba/nacl.patch View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
zentaro
Please take look.
5 years, 1 month ago (2015-11-20 02:35:11 UTC) #3
bradn
lgtm
5 years, 1 month ago (2015-11-20 03:28:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463173002/1
5 years, 1 month ago (2015-11-20 03:28:39 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-20 03:28:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463173002/1
5 years, 1 month ago (2015-11-20 03:41:36 UTC) #11
bradnelson
lgtm
5 years, 1 month ago (2015-11-20 03:41:37 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-20 03:41:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463173002/1
5 years, 1 month ago (2015-11-20 03:58:20 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 04:05:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/naclports/+/0d807fb9ccd1d588e7b0a2...

Powered by Google App Engine
This is Rietveld 408576698