content/browser/renderer_host/render_widget_host_delegate.cc - Issue 1463153002: Don't route a non-frame widget's keyboard event to main frame widget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.cc

Issue 1463153002: Don't route a non-frame widget's keyboard event to main frame widget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Charlie's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_delegate.h ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_delegate.cc

diff --git a/content/browser/renderer_host/render_widget_host_delegate.cc b/content/browser/renderer_host/render_widget_host_delegate.cc

index 2026575e41d01e67509969b8bc8245b0647f3528..0609826f1266b1a1cef4bd3ff5566ec86712cb8f 100644

--- a/content/browser/renderer_host/render_widget_host_delegate.cc

+++ b/content/browser/renderer_host/render_widget_host_delegate.cc

@@ -50,8 +50,9 @@ RenderWidgetHostDelegate::GetInputEventRouter() {

// If a delegate does not override this, the RenderWidgetHostView will

// assume its own RenderWidgetHost should consume keyboard events.

-RenderWidgetHostImpl* RenderWidgetHostDelegate::GetFocusedRenderWidgetHost() {

- return nullptr;

+RenderWidgetHostImpl* RenderWidgetHostDelegate::GetFocusedRenderWidgetHost(

+ RenderWidgetHostImpl* receiving_widget) {

+ return receiving_widget;

}

gfx::Rect RenderWidgetHostDelegate::GetRootWindowResizerRect(