DevTools: avoid layout thrashing on Layers panel

DevTools: avoid layout thrashing on Layers panel

- only adjust canvas size in Layers3DView upon resize and onShown;
- fix selection comparison in LayerViewHost to properly check member-wise equality;
- fix LayerTreeOutline's updateLayer() to properly check parent of root node;

BUG=

Committed: https://crrev.com/3f7c49812f4ef7271fd979356bf5aab2d85b573d
Cr-Commit-Position: refs/heads/master@{#361001}

[caseq, 2015-11-20 18:45:10]

caseq@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2015-11-20 22:48:52]

https://codereview.chromium.org/1463143005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (left):

https://codereview.chromium.org/1463143005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:866:
this.onreveal();
I think you want it there synchronously.

https://codereview.chromium.org/1463143005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (right):

https://codereview.chromium.org/1463143005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:304: if
(treeElement.treeOutline !== this || !treeElement.listItemElement)
nuke those

https://codereview.chromium.org/1463143005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:889:
_deferredScrollIntoView: function()
unused

[caseq, 2015-11-20 23:02:13]

ptal

[caseq, 2015-11-21 01:31:14]

ptal

[pfeldman, 2015-11-21 01:38:35]

lgtm for one of them, but we should split.

https://codereview.chromium.org/1463143005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
(right):

https://codereview.chromium.org/1463143005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:663:
treeElement.reveal(false);
no need to change.

https://codereview.chromium.org/1463143005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (right):

https://codereview.chromium.org/1463143005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:198:
nextSelectedElement.reveal(false);
ditto

https://codereview.chromium.org/1463143005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:214:
nextSelectedElement.reveal(false);
ditto

https://codereview.chromium.org/1463143005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:257:
this.selectedTreeElement.reveal(false);
ditto

https://codereview.chromium.org/1463143005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:281:
nextSelectedElement.reveal(false);
ditto

[caseq, 2015-11-21 01:46:36]

The CQ bit was checked by caseq@chromium.org

[caseq, 2015-11-21 01:46:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1463143005/#ps60001
(title: "extracted reveal() change")

[caseq, 2015-11-21 01:48:06]

Description was changed from

==========
DevTools: avoid layout thrashing on Layers panel

- defer scrollIntoViewIfNeeded() in TreeOutline with rAF to avoid forcing
layout;
- only adjust canvas size in Layers3DView upon resize and onShown;
- fix selection comparison in LayerViewHost to properly check member-wise
equality;
- fix LayerTreeOutline's updateLayer() to properly check parent of root node;

BUG=
==========

to

==========
DevTools: avoid layout thrashing on Layers panel

- only adjust canvas size in Layers3DView upon resize and onShown;
- fix selection comparison in LayerViewHost to properly check member-wise
equality;
- fix LayerTreeOutline's updateLayer() to properly check parent of root node;

BUG=
==========

[commit-bot: I haz the power, 2015-11-21 01:48:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1463143005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1463143005/60001

[commit-bot: I haz the power, 2015-11-21 04:01:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-21 04:02:26]

Patchset 4 (id:??) landed as
https://crrev.com/3f7c49812f4ef7271fd979356bf5aab2d85b573d
Cr-Commit-Position: refs/heads/master@{#361001}