Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1463143004: [release] Add json output to release tools. (Closed)

Created:
5 years, 1 month ago by Michael Achenbach
Modified:
5 years, 1 month ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[release] Add json output to release tools. This will allow callers (e.g. the infra recipe) to check which steps have been executed and monitor success/failure. BUG=chromium:559141 LOG=n NOTRY=true Committed: https://crrev.com/cded3ea64f3a24ea0cb716204cfbc2d44ad3fa03 Cr-Commit-Position: refs/heads/master@{#32150}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -48 lines) Patch
M tools/release/auto_roll.py View 4 chunks +4 lines, -26 lines 1 comment Download
M tools/release/common_includes.py View 3 chunks +15 lines, -4 lines 0 comments Download
M tools/release/test_scripts.py View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1463143004/diff/1/tools/release/auto_roll.py File tools/release/auto_roll.py (left): https://codereview.chromium.org/1463143004/diff/1/tools/release/auto_roll.py#oldcode16 tools/release/auto_roll.py:16: class CheckActiveRoll(Step): Removing this here as it is ...
5 years, 1 month ago (2015-11-20 13:55:49 UTC) #3
Michael Hablich
On 2015/11/20 13:55:49, Michael Achenbach wrote: > PTAL > > https://codereview.chromium.org/1463143004/diff/1/tools/release/auto_roll.py > File tools/release/auto_roll.py (left): ...
5 years, 1 month ago (2015-11-20 14:44:00 UTC) #4
Michael Achenbach
On 2015/11/20 14:44:00, Hablich wrote: > On 2015/11/20 13:55:49, Michael Achenbach wrote: > > PTAL ...
5 years, 1 month ago (2015-11-20 14:47:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463143004/1
5 years, 1 month ago (2015-11-20 14:48:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 14:49:34 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 14:50:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cded3ea64f3a24ea0cb716204cfbc2d44ad3fa03
Cr-Commit-Position: refs/heads/master@{#32150}

Powered by Google App Engine
This is Rietveld 408576698