Issue 14631019: Remove internal handlers from the Files.app's UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14631019: Remove internal handlers from the Files.app's UI. (Closed)

Created:
7 years, 7 months ago by mtomasz

Modified:
7 years, 7 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove internal handlers from the Files.app's UI. Recently, internal handlers have been added to the manifest to work in Files.app V2, which caused a regression - these internal handlers appeared in the UI, which is unexpected. This patch fixes this issue by hiding theses tasks. TEST=Enter Files.app, click on a picture, there should not be __MSG_OPEN_ACTION__ entries next to the Delete button. BUG=239044 R=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199417

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/resources/file_manager/js/file_tasks.js	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14631019/1

7 years, 7 months ago (2013-05-10 05:08:36 UTC) #3

mtomasz

7 years, 7 months ago (2013-05-10 07:45:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r199417 (presubmit successful).

Expand Messages | Collapse Messages