Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 14631013: Put llvm.powi in the dev list of intrinsics. (Closed)

Created:
7 years, 7 months ago by jvoung (off chromium)
Modified:
7 years, 7 months ago
Reviewers:
Derek Schuff, eliben
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

Put llvm.powi in the dev list of intrinsics. This is used by the LLVM translator as part of: lib/Analysis/ConstantFolding.cpp (it tries to do constant folding for pow calls...) Also, tweak comment about llvm.pow vs llvm.powi. It looks like powi is the imprecise one, not pow. BUG=unblock DEPs roll, broken self-build. BUG=http://code.google.com/p/nativeclient/issues/detail?id=3378 R=eliben@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=e6d4584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M lib/Analysis/NaCl/PNaClABIVerifyModule.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jvoung (off chromium)
7 years, 7 months ago (2013-05-08 01:16:13 UTC) #1
eliben
lgtm
7 years, 7 months ago (2013-05-08 16:08:35 UTC) #2
jvoung (off chromium)
7 years, 7 months ago (2013-05-08 16:40:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as re6d4584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698