Files.app: Make the design of search box match the spec.

Files.app: Make the design of search box match the spec.

The size of new version's search box is changed depending on whether the
search box has text or not. Thus this CL added a new CSS class 'has-text' to
the #search-box input, which is updated by JavaScript.

BUG=237149
TEST=Open files.app, input text to the search box
R=yoshiki@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199702

[hirono, 2013-05-07 07:37:31]

Yoshiki-san, could you check the CL?
Thank you!

[yoshiki, 2013-05-10 06:06:15]

https://codereview.chromium.org/14631008/diff/13001/chrome/browser/resources/...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/14631008/diff/13001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/file_manager.js:902:
autocompleteList.attachToInput = function(input) {
Ideally, it's better to create a separate class which inherits AutocompleteList
rather than overriding methods. But I'm sure this patch will go to merge to the
branch and we should make the diff smaller. As for now, it's better to keep the
patch as your way is.

Could you add a TODO comment and file an issue to create the separate class and
move it there?

https://codereview.chromium.org/14631008/diff/13001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/file_manager.js:912: this.style.left =
(leftNumber + offset) + 'px';
This seems hacky. How about adding a CSS class to set 16px margin to shift the
position?

https://codereview.chromium.org/14631008/diff/13001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/file_manager.js:3296: if
(this.searchBox_.value) {
nit: Remove braces.

[hirono, 2013-05-13 08:14:13]

Fixed.

Thank you!

https://codereview.chromium.org/14631008/diff/13001/chrome/browser/resources/...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/14631008/diff/13001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/file_manager.js:902:
autocompleteList.attachToInput = function(input) {
On 2013/05/10 06:06:15, yoshiki wrote:
> Ideally, it's better to create a separate class which inherits
AutocompleteList
> rather than overriding methods. But I'm sure this patch will go to merge to
the
> branch and we should make the diff smaller. As for now, it's better to keep
the
> patch as your way is.
> 
> Could you add a TODO comment and file an issue to create the separate class
and
> move it there?

I just removed these codes.

https://codereview.chromium.org/14631008/diff/13001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/file_manager.js:912: this.style.left =
(leftNumber + offset) + 'px';
On 2013/05/10 06:06:15, yoshiki wrote:
> This seems hacky. How about adding a CSS class to set 16px margin to shift the
> position?

Done.

https://codereview.chromium.org/14631008/diff/13001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/file_manager.js:3296: if
(this.searchBox_.value) {
On 2013/05/10 06:06:15, yoshiki wrote:
> nit: Remove braces.

I removed the if statement.

[yoshiki, 2013-05-13 08:47:21]

Could you check if the legacy ui is still working? If ok, lgtm.

[hirono, 2013-05-13 10:24:59]

On 2013/05/13 08:47:21, yoshiki wrote:
> Could you check if the legacy ui is still working? If ok, lgtm.

I fixed CSS to fix legacy and RTL UI.
Could you check it?

Thank you.

[yoshiki, 2013-05-13 10:27:14]

still lgtm

[hirono, 2013-05-13 10:27:44]

On 2013/05/13 10:27:14, yoshiki wrote:
> still lgtm

Thanks!

[yoshiki, 2013-05-13 10:48:58]

Committed patchset #7 manually as r199702 (presubmit successful).