chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc - Issue 14631005: Enable users of NotificationUIManager to specify binary images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc

Issue 14631005: Enable users of NotificationUIManager to specify binary images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove fake image from synced notification, stop checking icon_url in unit test. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification.h ('K') | « chrome/browser/notifications/sync_notifier/synced_notification.cc ('k') | ui/message_center/cocoa/notification_controller_unittest.mm » ('j') | ui/message_center/notification.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc

diff --git a/chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc b/chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc

index 6d7061dc2020828f2f54ba53ff30f5edd2ab73fe..7bccd382286df2770b628004b15264a86a6912dd 100644

--- a/chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc

+++ b/chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc

@@ -589,7 +589,6 @@ TEST_F(SyncedNotificationTest, ShowTest) {

UTF16ToUTF8(notification_manager.notification().body()));

EXPECT_EQ(kExpectedOriginUrl,

notification_manager.notification().origin_url().spec());

- EXPECT_EQ(kIconUrl1, notification_manager.notification().icon_url().spec());

EXPECT_EQ(kKey1,

UTF16ToUTF8(notification_manager.notification().replace_id()));

const DictionaryValue* actual_fields =