chrome/browser/notifications/desktop_notification_service.cc - Issue 14631005: Enable users of NotificationUIManager to specify binary images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service.cc

Issue 14631005: Enable users of NotificationUIManager to specify binary images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase for relanding. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/system/web_notification/web_notification_tray_unittest.cc ('k') | chrome/browser/notifications/desktop_notification_service_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/desktop_notification_service.cc

diff --git a/chrome/browser/notifications/desktop_notification_service.cc b/chrome/browser/notifications/desktop_notification_service.cc

index d3bf8ab7976e9f7dd1c716a9b8f18416a29fc10b..3479ade07c2200abe30b8f53bdafe17246013acf 100644

--- a/chrome/browser/notifications/desktop_notification_service.cc

+++ b/chrome/browser/notifications/desktop_notification_service.cc

@@ -512,7 +512,7 @@ bool DesktopNotificationService::ShowDesktopNotification(

params.body, params.direction, display_source, params.replace_id,

proxy);

// The webkit notification doesn't timeout.

- notification.DisableTimeout();

+ notification.set_never_timeout(true);

ShowNotification(notification);

}

return true;