Enable users of NotificationUIManager to specify binary images.

chrome/browser/notifications/notification.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
 #include "base/values.h"
 #include "chrome/browser/notifications/notification_delegate.h"
 #include "googleurl/src/gurl.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebTextDirection.h"
 #include "ui/gfx/image/image.h"
+#include "ui/message_center/notification.h"
 #include "ui/message_center/notification_types.h"
 
 // Representation of a notification to be shown to the user.
 // On non-Ash platforms these are rendered as HTML, sometimes described by a
 // data url converted from text + icon data. On Ash they are rendered as
 // formated text and icon data.
 class Notification {

[Jun Mukai, 2013/05/31 17:08:10]

Can we make this class a subclass of message_center::Notification instead of
adding RichNotificationData?  as you did NotificationDelegate?

[dewittj, 2013/05/31 22:13:56]

Not easily, since the prevailing style is to pass around const references of
chrome/browser/notification but to pass around scoped_ptr of
ui/message_center/notification.

  public:
   // Initializes a notification with HTML content.
   Notification(const GURL& origin_url,
                const GURL& content_url,
                const string16& display_source,
                const string16& replace_id,
                NotificationDelegate* delegate);
 
   // Initializes a notification with text content. On non-ash platforms, this
   // creates an HTML representation using a data: URL for display.
@@ skipping 23 matching lines @@
   // only used on Ash. Does not generate content_url_.
   Notification(const GURL& origin_url,
                const gfx::Image& icon,
                const string16& title,
                const string16& body,
                WebKit::WebTextDirection dir,
                const string16& display_source,
                const string16& replace_id,
                NotificationDelegate* delegate);
 
+  Notification(
+      message_center::NotificationType type,
+      const GURL& origin_url,
+      const string16& title,
+      const string16& body,
+      WebKit::WebTextDirection dir,
+      const string16& display_source,
+      const string16& replace_id,
+      const message_center::RichNotificationData& rich_notification_data,
+      NotificationDelegate* delegate);
+
   Notification(const Notification& notification);
   ~Notification();
   Notification& operator=(const Notification& notification);
 
   // If this is a HTML notification.
   bool is_html() const { return is_html_; }
 
   message_center::NotificationType type() const {
     return type_;
   }
@@ skipping 37 matching lines @@
   void DoneRendering() { delegate()->ReleaseRenderViewHost(); }
 
   std::string notification_id() const { return delegate()->id(); }
 
   int process_id() const { return delegate()->process_id(); }
 
   content::RenderViewHost* GetRenderViewHost() const {
     return delegate()->GetRenderViewHost();
   }
 
+  bool has_rich_notification() const { return has_rich_notification_; }
+  const message_center::RichNotificationData& rich_notification_data() const {
+    return rich_notification_data_;
+  }
+
   NotificationDelegate* delegate() const { return delegate_.get(); }
 
  private:
   // The type of notification we'd like displayed.
   message_center::NotificationType type_;
 
   // The Origin of the page/worker which created this notification.
   GURL origin_url_;
 
   // Image data for the associated icon, used by Ash when available.
@@ skipping 17 matching lines @@
 
   // The display string for the source of the notification.  Could be
   // the same as origin_url_, or the name of an extension.
   string16 display_source_;
 
   // The replace ID for the notification.
   string16 replace_id_;
 
   scoped_ptr<DictionaryValue> optional_fields_;
 
+  bool has_rich_notification_;
+  message_center::RichNotificationData rich_notification_data_;
+
   // A proxy object that allows access back to the JavaScript object that
   // represents the notification, for firing events.
   scoped_refptr<NotificationDelegate> delegate_;
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_H_