Issue 1463083004: Change IS_OBJECT back to typeof == "object" and use IS_SPEC_OBJECT in Array.from and RegExp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1463083004: Change IS_OBJECT back to typeof == "object" and use IS_SPEC_OBJECT in Array.from and RegExp (Closed)

Created:
5 years, 1 month ago by Toon Verwaest

Modified:
5 years, 1 month ago

Reviewers:
Igor Sheludko

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Change IS_OBJECT back to typeof == "object" and use IS_SPEC_OBJECT in Array.from and RegExp BUG= Committed: https://crrev.com/ea6cf207578178332f3e16a84fca1d90bdba11e6 Cr-Commit-Position: refs/heads/master@{#32143}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	src/js/array.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/js/macros.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/js/regexp.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463083004/1

5 years, 1 month ago (2015-11-20 11:33:07 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-20 11:57:52 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ea6cf207578178332f3e16a84fca1d90bdba11e6
Cr-Commit-Position: refs/heads/master@{#32143}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages