Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1463013003: Unexpose ResourceRequestInfo::GetRequestID. (Closed)

Created:
5 years, 1 month ago by davidben
Modified:
5 years, 1 month ago
Reviewers:
nasko
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unexpose ResourceRequestInfo::GetRequestID. This is never used outside of //content. BUG=376003 Committed: https://crrev.com/e7325fc3acb3de298d65726950c4e040b7ac9ab4 Cr-Commit-Position: refs/heads/master@{#361206}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : CONTENT_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M content/browser/download/download_resource_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/browser/resource_request_info.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
davidben
5 years, 1 month ago (2015-11-20 23:04:11 UTC) #2
nasko
LGTM https://codereview.chromium.org/1463013003/diff/40001/content/browser/loader/resource_request_info_impl.h File content/browser/loader/resource_request_info_impl.h (right): https://codereview.chromium.org/1463013003/diff/40001/content/browser/loader/resource_request_info_impl.h#newcode97 content/browser/loader/resource_request_info_impl.h:97: int GetRequestID() const; You probably want CONTENT_EXPORT on ...
5 years, 1 month ago (2015-11-23 18:16:07 UTC) #3
davidben
https://codereview.chromium.org/1463013003/diff/40001/content/browser/loader/resource_request_info_impl.h File content/browser/loader/resource_request_info_impl.h (right): https://codereview.chromium.org/1463013003/diff/40001/content/browser/loader/resource_request_info_impl.h#newcode97 content/browser/loader/resource_request_info_impl.h:97: int GetRequestID() const; On 2015/11/23 18:16:06, nasko wrote: > ...
5 years, 1 month ago (2015-11-23 19:24:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463013003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463013003/60001
5 years, 1 month ago (2015-11-23 21:55:35 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-23 22:47:02 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 22:47:42 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e7325fc3acb3de298d65726950c4e040b7ac9ab4
Cr-Commit-Position: refs/heads/master@{#361206}

Powered by Google App Engine
This is Rietveld 408576698