Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1463013002: Use ThreadChecker in HistogramDeltaSerialization class. (Closed)

Created:
5 years, 1 month ago by Alexei Svitkine (slow)
Modified:
5 years, 1 month ago
Reviewers:
Will Harris
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ThreadChecker in HistogramDeltaSerialization class. There's a suspicion that this code might be being used from multiple threads. Add a ThreadChecker to make sure this isn't happening. NOTE: These checks will still only be active in debug builds, but if they pass all the bots (that do run with dchecks on) and for developer builds, then I think it's pretty safe to assume there's no issue here. But good to have the precaution. BUG=554011 Committed: https://crrev.com/0b6761ff0d1339e11707b6459152396320acc1b8 Cr-Commit-Position: refs/heads/master@{#360689}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M base/metrics/histogram_delta_serialization.h View 2 chunks +3 lines, -0 lines 0 comments Download
M base/metrics/histogram_delta_serialization.cc View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Alexei Svitkine (slow)
5 years, 1 month ago (2015-11-19 22:06:10 UTC) #4
Will Harris
lgtm. will you consider changing these to CHECK() if no failures are seen on the ...
5 years, 1 month ago (2015-11-19 22:35:36 UTC) #5
Alexei Svitkine (slow)
On 2015/11/19 22:35:36, Will Harris wrote: > lgtm. will you consider changing these to CHECK() ...
5 years, 1 month ago (2015-11-19 23:09:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463013002/20001
5 years, 1 month ago (2015-11-19 23:12:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-19 23:49:56 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 23:50:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b6761ff0d1339e11707b6459152396320acc1b8
Cr-Commit-Position: refs/heads/master@{#360689}

Powered by Google App Engine
This is Rietveld 408576698