Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 14630016: Getting html_dart2js and html_dartium a bit more in sync. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 107961528981c75dd7f9ad625c29bfcb507a9ebc..c846fda993727fa878899baf75a96ea8f20bd57c 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -65,7 +65,7 @@ _callPortSync(int id, message) {
return JS('var', r'ReceivePortSync.dispatchCall(#, #)', id, message);
}
-spawnDomFunction(f) => IsolateNatives.spawnDomFunction(f);
+spawnDomFunction(Function f) => IsolateNatives.spawnDomFunction(f);
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -1527,7 +1527,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext native "CanvasRend
'#.lineDashOffset || #.webkitLineDashOffset', this, this);
@DomName('CanvasRenderingContext2D.lineDashOffset')
- void set lineDashOffset(num value) => JS('void',
+ void set lineDashOffset(num value) => JS('void',
'typeof #.lineDashOffset != "undefined" ? #.lineDashOffset = # : '
'#.webkitLineDashOffset = #', this, this, value, this, value);
}
@@ -1637,7 +1637,7 @@ class CompositionEvent extends UIEvent native "CompositionEvent" {
@DomName('Console')
class Console {
- static Console safeConsole = new Console();
+ static Console _safeConsole = new Console();
bool get _isConsoleDefined => JS('bool', 'typeof console != "undefined"');
@@ -1710,8 +1710,8 @@ class Console {
JS('void', 'console.time(#)', title) : null;
@DomName('Console.timeEnd')
- void timeEnd(String timerName) => _isConsoleDefined ?
- JS('void', 'console.timeEnd(#)', timerName) : null;
+ void timeEnd(String title) => _isConsoleDefined ?
+ JS('void', 'console.timeEnd(#)', title) : null;
@DomName('Console.timeStamp')
void timeStamp(Object arg) => _isConsoleDefined ?
@@ -7510,11 +7510,11 @@ abstract class Element extends Node implements ElementTraversal native "Element"
* * [insertAdjacentText]
* * [insertAdjacentElement]
*/
- void insertAdjacentHtml(String where, String text) {
+ void insertAdjacentHtml(String where, String html) {
if (JS('bool', '!!#.insertAdjacentHtml', this)) {
- _insertAdjacentHtml(where, text);
+ _insertAdjacentHtml(where, html);
} else {
- _insertAdjacentNode(where, new DocumentFragment.html(text));
+ _insertAdjacentNode(where, new DocumentFragment.html(html));
}
}
@@ -20498,9 +20498,9 @@ class Url native "URL" {
'(window.URL || window.webkitURL).createObjectURL(#)',
blob_OR_source_OR_stream);
- static void revokeObjectUrl(String objectUrl) =>
+ static void revokeObjectUrl(String url) =>
JS('void',
- '(window.URL || window.webkitURL).revokeObjectURL(#)', objectUrl);
+ '(window.URL || window.webkitURL).revokeObjectURL(#)', url);
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -21211,7 +21211,7 @@ class Window extends EventTarget implements WindowBase native "Window,DOMWindow"
return _requestAnimationFrame(callback);
}
- void cancelAnimationFrame(id) {
+ void cancelAnimationFrame(int id) {
_ensureRequestAnimationFrame();
_cancelAnimationFrame(id);
}
@@ -21264,7 +21264,7 @@ class Window extends EventTarget implements WindowBase native "Window,DOMWindow"
this, this, this);
@DomName('Window.console')
- Console get console => Console.safeConsole;
+ Console get console => Console._safeConsole;
/// Checks if _setImmediate is supported.
static bool get _supportsSetImmediate =>
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('J')

Powered by Google App Engine
This is Rietveld 408576698