signin: move SigninManagerBase::Signout to SigninManager.

chrome/browser/ui/webui/sync_setup_handler.cc

Index: chrome/browser/ui/webui/sync_setup_handler.cc
diff --git a/chrome/browser/ui/webui/sync_setup_handler.cc b/chrome/browser/ui/webui/sync_setup_handler.cc
index cc40700a63846b5592863da146d5c6fd0461f2bb..d230c26ecec9fa3e0b534fff614843c15d710c2f 100644
--- a/chrome/browser/ui/webui/sync_setup_handler.cc
+++ b/chrome/browser/ui/webui/sync_setup_handler.cc
@@ -1090,8 +1090,9 @@ void SyncSetupHandler::HandleStartSignin(const ListValue* args) {
 void SyncSetupHandler::HandleStopSyncing(const ListValue* args) {
   if (GetSyncService())
     ProfileSyncService::SyncEvent(ProfileSyncService::STOP_FROM_OPTIONS);
-
+#if !defined(OS_CHROMEOS)
   SigninManagerFactory::GetForProfile(GetProfile())->SignOut();
+#endif
 }
 
 void SyncSetupHandler::HandleCloseTimeout(const ListValue* args) {
@@ -1128,6 +1129,8 @@ void SyncSetupHandler::CloseSyncSetup() {
     // and shut down sync.
     if (!sync_service->HasSyncSetupCompleted()) {
       DVLOG(1) << "Signin aborted by user action";
+#if !defined(OS_CHROMEOS)
+        // TODO(tim): Is this path even reachable on Chrome OS?

[Andrew T Wilson (Slow), 2013/05/06 09:06:00]

Possibly - the way I'd guess is:

1) User does dashboard clear
2) User clicks to re-enable sync, going through Advanced path.
3) User cancels out of Advanced dialog.

I think doing nothing here on ChromeOS is OK.

[tim (not reviewing), 2013/05/06 17:28:57]

Done.

       if (signin_tracker_.get() || sync_service->FirstSetupInProgress()) {
         // User was still in the process of signing in, so sign him out again.
         // This makes sure that the user isn't left signed in but with sync
@@ -1146,6 +1149,7 @@ void SyncSetupHandler::CloseSyncSetup() {
         // right thing for the one-click case.
         SigninManagerFactory::GetForProfile(GetProfile())->SignOut();
       }
+#endif
       sync_service->DisableForUser();
       browser_sync::SyncPrefs sync_prefs(GetProfile()->GetPrefs());
       sync_prefs.SetStartSuppressed(true);
@@ -1310,6 +1314,8 @@ void SyncSetupHandler::CloseGaiaSigninPage() {
   }
 }
 
+#if !defined(OS_CHROMEOS)
+// Used by HandleSubmitAuth.
 bool SyncSetupHandler::IsLoginAuthDataValid(const std::string& username,
                                             string16* error_message) {
   if (username.empty())
@@ -1346,3 +1352,5 @@ bool SyncSetupHandler::IsLoginAuthDataValid(const std::string& username,
 
   return true;
 }
+
+#endif  // !defined(OS_CHROMEOS)