Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1462983002: Record concat as Concat. (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Record concat as Concat. This seems to cause very slight diffs on GMs. https://gold.skia.org/search2?issue=1462983002&unt=true&query=source_type%3Dgm&master=false I'm not sure I understand why. The diffs to at least pictureshader look like improvements. BUG=skia:4584 Committed: https://skia.googlesource.com/skia/+/e9d2052e4931eeade49042a855b9c1f5ab7c84c5

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M include/private/SkRecords.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 7 chunks +10 lines, -7 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462983002/1
5 years, 1 month ago (2015-11-19 18:41:14 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/4294)
5 years, 1 month ago (2015-11-19 18:45:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462983002/20001
5 years, 1 month ago (2015-11-19 18:49:45 UTC) #6
mtklein_C
5 years, 1 month ago (2015-11-19 18:55:12 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 19:03:37 UTC) #11
reed1
lgtm do we think this has any impact on performance when using RTree?
5 years, 1 month ago (2015-11-19 20:06:21 UTC) #12
mtklein
On 2015/11/19 at 20:06:21, reed wrote: > lgtm > > do we think this has ...
5 years, 1 month ago (2015-11-19 20:07:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462983002/20001
5 years, 1 month ago (2015-11-19 20:07:45 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 20:08:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e9d2052e4931eeade49042a855b9c1f5ab7c84c5

Powered by Google App Engine
This is Rietveld 408576698