Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: components/variations/android/variations_seed_bridge.h

Issue 1462953004: Unit tests for importing prefs from the Java side implemented (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes according to code review comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_VARIATIONS_ANDROID_VARIATIONS_SEED_BRIDGE_H_ 5 #ifndef COMPONENTS_VARIATIONS_ANDROID_VARIATIONS_SEED_BRIDGE_H_
6 #define COMPONENTS_VARIATIONS_ANDROID_VARIATIONS_SEED_BRIDGE_H_ 6 #define COMPONENTS_VARIATIONS_ANDROID_VARIATIONS_SEED_BRIDGE_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 #include <string> 9 #include <string>
10 10
(...skipping 10 matching lines...) Expand all
21 bool* is_gzip_compressed); 21 bool* is_gzip_compressed);
22 22
23 // Clears first run seed preferences stored on the Java side of Chrome for 23 // Clears first run seed preferences stored on the Java side of Chrome for
24 // Android. 24 // Android.
25 void ClearJavaFirstRunPrefs(); 25 void ClearJavaFirstRunPrefs();
26 26
27 // Marks variations seed as stored to avoid repeated fetches of the seed at 27 // Marks variations seed as stored to avoid repeated fetches of the seed at
28 // the Java side. 28 // the Java side.
29 void MarkVariationsSeedAsStored(); 29 void MarkVariationsSeedAsStored();
30 30
31 // Sets test data on the Java side. The data is pulled during the unit tests to
32 // C++ side and is being checked for consistency.
33 // This method is used for unit testing purposes only.
34 void SetTestData(std::string seed_data,
Alexei Svitkine (slow) 2015/11/20 19:10:33 Nit: SetJavaFirstRunPrefsForTesting()
Alexander Agulenko 2015/11/20 19:24:04 Done.
35 std::string seed_signature,
36 std::string seed_country,
37 std::string response_date,
Alexei Svitkine (slow) 2015/11/20 19:10:33 Make params "const std::string&"
Alexander Agulenko 2015/11/20 19:24:04 Done (shame-shame-shame).
38 bool is_gzip_compressed);
39
31 } // namespace android 40 } // namespace android
32 } // namespace variations 41 } // namespace variations
33 42
34 #endif // COMPONENTS_VARIATIONS_ANDROID_FIRSTRUN_VARIATIONS_SEED_BRIDGE_H_ 43 #endif // COMPONENTS_VARIATIONS_ANDROID_FIRSTRUN_VARIATIONS_SEED_BRIDGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698