Unit tests for importing prefs from the Java side implemented

components/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 import("//tools/grit/repack.gni")
 
 if (is_android) {
@@ skipping 29 matching lines @@
     "//components/device_event_log",
     "//components/dom_distiller/core",
     "//components/enhanced_bookmarks",
     "//components/favicon/core",
     "//components/favicon_base",
     "//components/gcm_driver",
     "//components/google/core/browser",
     "//components/history/core/browser",
     "//components/history/core/common",
     "//components/history/core/test",
+    "//components/infobars/core",

[Alexei Svitkine (slow), 2015/11/20 16:28:28]

These diffs don't look right.

[Alexander Agulenko, 2015/11/20 17:33:31]

gn format --in-place just sorted everything alphabetically. It is really
strange, and I agree to revert this file to initial state. What do yoy think?

+    "//components/invalidation/impl",
+    "//components/invalidation/public",
     "//components/keyed_service/core",
+    "//components/leveldb_proto",
     "//components/metrics",
     "//components/net_log",
     "//components/network_time",
     "//components/ntp_snippets",
+    "//components/omnibox/browser",
+    "//components/open_from_clipboard",
+    "//components/os_crypt",
     "//components/password_manager/core/browser",
     "//components/password_manager/core/common",
     "//components/password_manager/sync/browser",
+    "//components/pref_registry",
+    "//components/proxy_config",
+    "//components/rappor",
     "//components/search",
     "//components/search_engines",
     "//components/sessions",
+    "//components/signin/core/browser",
+    "//components/strings",
+    "//components/suggestions",
     "//components/sync_bookmarks",
-    "//components/undo",
-    "//components/update_client",
-    "//components/strings",
-    "//components/leveldb_proto",
-    "//components/pref_registry",
-    "//components/rappor",
-    "//components/proxy_config",
-    "//components/omnibox/browser",
-    "//components/open_from_clipboard",
-    "//components/infobars/core",
-    "//components/invalidation/impl",
-    "//components/invalidation/public",
-    "//components/signin/core/browser",
-    "//components/suggestions",
     "//components/sync_driver",
     "//components/syncable_prefs",
     "//components/translate/core/browser",
     "//components/translate/core/common",
+    "//components/undo",
+    "//components/update_client",
     "//components/upload_list",
     "//components/variations",
     "//components/variations/service",
     "//components/version_info",
     "//components/version_ui",
-    "//components/os_crypt",
     "//components/web_resource",
     "//components/webdata_services",
   ]
 
   if (!is_ios) {
     deps += [
-      "//components/bitmap_uploader",
-      "//components/certificate_reporting",
-      "//components/cdm/browser",
       "//components/about_handler",
+      "//components/app_modal",
       "//components/auto_login_parser",
       "//components/autofill/content/browser",
       "//components/autofill/content/common",
       "//components/autofill/content/renderer",
+      "//components/bitmap_uploader",
+      "//components/browsing_data",
       "//components/bubble",
       "//components/captive_portal",
       "//components/cdm/browser",
+      "//components/cdm/browser",
       "//components/cdm/common",
       "//components/cdm/renderer",
+      "//components/certificate_reporting",
+      "//components/certificate_transparency",
+      "//components/chrome_apps",
       "//components/cloud_devices/common",
-      "//components/chrome_apps",
       "//components/compression",
       "//components/cookie_config",
       "//components/crash/content/app",
       "//components/crash/content/browser",
       "//components/crx_file",
       "//components/data_reduction_proxy/core/browser",
       "//components/data_reduction_proxy/core/common",
       "//components/device_event_log",
       "//components/devtools_discovery",
       "//components/devtools_http_handler",
       "//components/domain_reliability",
       "//components/exo",
       "//components/exo/wayland",
       "//components/feedback",
       "//components/gcm_driver/crypto",
       "//components/gcm_driver/instance_id",
+      "//components/guest_view/browser",
+      "//components/guest_view/common",
+      "//components/guest_view/renderer",
       "//components/history/content/browser",
       "//components/json_schema",
       "//components/keyed_service/content",
       "//components/language_usage_metrics",
       "//components/login",
       "//components/memory_pressure",
       "//components/metrics_services_manager",
       "//components/mime_util",
       "//components/navigation_interception",
       "//components/navigation_metrics",
       "//components/network_hints/browser",
       "//components/network_hints/common",
       "//components/network_hints/renderer",
       "//components/offline_pages",
       "//components/onc",
       "//components/packed_ct_ev_whitelist",
       "//components/pairing",
       "//components/password_manager/content/browser",
       "//components/pdf/browser",
       "//components/pdf/common",
       "//components/pdf/renderer",
       "//components/plugins/renderer",
       "//components/power",
+      "//components/precache/content",
       "//components/precache/core",
-      "//components/precache/content",
       "//components/query_parser",
       "//components/renderer_context_menu",
       "//components/resources:components_resources",
       "//components/safe_browsing_db",
+      "//components/safe_json",
+      "//components/scheduler",
       "//components/search_provider_logos",
       "//components/security_interstitials/core",
       "//components/ssl_config",
+      "//components/startup_metric_utils/browser",
       "//components/startup_metric_utils/common",
-      "//components/startup_metric_utils/browser",
       "//components/sync_sessions",
+      "//components/test_runner",
       "//components/tracing",
       "//components/tracing:startup_tracing",
       "//components/translate/content/browser",
       "//components/translate/content/common",
       "//components/translate/content/renderer",
       "//components/ui/zoom",
       "//components/url_formatter",
       "//components/url_matcher",
       "//components/user_manager",
       "//components/user_prefs",
       "//components/user_prefs/tracked:user_prefs_tracked",
       "//components/visitedlink/browser",
       "//components/visitedlink/common",
       "//components/visitedlink/renderer",
       "//components/wallpaper",
       "//components/web_cache/browser",
       "//components/web_cache/common",
       "//components/web_cache/renderer",
       "//components/web_modal",
       "//components/webcrypto",
+      "//components/webcrypto",
       "//components/webdata/common",
       "//components/wifi",
       "//components/wifi_sync",
-      "//components/app_modal",
-      "//components/browsing_data",
-      "//components/certificate_transparency",
-      "//components/guest_view/browser",
-      "//components/guest_view/common",
-      "//components/guest_view/renderer",
-      "//components/safe_json",
-      "//components/scheduler",
-      "//components/test_runner",
-      "//components/webcrypto",
     ]
 
     if (enable_configuration_policy) {
       deps += [ "//components/policy" ]
     }
 
     if (!is_chromeos || !enable_extensions) {
       deps -= [ "//components/chrome_apps" ]
     }
 
     if (!enable_plugins) {
       deps -= [
         "//components/pdf/browser",
         "//components/pdf/common",
         "//components/pdf/renderer",
       ]
     }
 
     if (!is_android) {
       # TODO(agrieve): Add to main deps list once compile errors are resolved.
       deps += [
         "//components/audio_modem",
+        "//components/copresence",
         "//components/proximity_auth",
         "//components/proximity_auth/cryptauth",
+        "//components/storage_monitor",
         "//components/webusb",
-        "//components/copresence",
-        "//components/storage_monitor",
       ]
     }
 
     if (!is_win && !is_mac) {
       deps -= [ "//components/wifi" ]
     }
 
     if (!is_chromeos) {
       deps -= [
         "//components/pairing",
@@ skipping 26 matching lines @@
 
   if (toolkit_views) {
     deps += [ "//components/constrained_window" ]
   }
 
   if (is_android) {
     deps -= [
       "//components/autofill/content/browser",  # Blocked on content/blink.
       "//components/autofill/content/common",  # Blocked on content.
       "//components/autofill/content/renderer",  # Blocked on content/blink.
-      "//components/crash/content/app",  # Should work, needs checking.
-      "//components/crash/content/browser",  # Should work, needs checking.
       "//components/captive_portal",  # Should work, needs checking.
-      "//components/cloud_devices/common",  # Should work, needs checking.
       "//components/cdm/browser",  # Blocked on content.
       "//components/cdm/common",  # Blocked on content.
       "//components/cdm/renderer",  # Blocked on content.
+      "//components/cloud_devices/common",  # Should work, needs checking.
+      "//components/crash/content/app",  # Should work, needs checking.
+      "//components/crash/content/browser",  # Should work, needs checking.
       "//components/data_reduction_proxy/core/browser",  # Should work, needs checking.
       "//components/data_reduction_proxy/core/common",  # Should work, needs checking.
       "//components/dom_distiller/core",  # Blocked on content.
       "//components/domain_reliability",  # Blocked on content.
       "//components/favicon/core",  # Blocked on keyed service.
       "//components/favicon_base",  # Should work, needs checking.
       "//components/feedback",  # Blocked on content.
       "//components/google/core/browser",  # Should work, needs checking.
       "//components/history/core/browser",  # Should work, needs checking.
       "//components/history/core/common",  # Should work, needs checking.
       "//components/history/core/test",  # Should work, needs checking.
       "//components/infobars/core",  # Should work, needs checking.
       "//components/invalidation/impl",  # Should work, needs checking.
       "//components/invalidation/public",  # Should work, needs checking.
       "//components/json_schema",  # Should work, needs checking.
+      "//components/keyed_service/content",  # Blocked on content.
       "//components/keyed_service/core",  # Blocked on content.
-      "//components/keyed_service/content",  # Blocked on content.
       "//components/navigation_interception",  # Blocked on content.
       "//components/omnibox/browser",  # Should work, needs checking.
       "//components/password_manager/content/browser",  # Blocked on content.
       "//components/password_manager/core/browser",  # Should work, needs checking.
       "//components/password_manager/core/common",  # Should work, needs checking.
       "//components/plugins/renderer",  # Blocked on blink.
+      "//components/policy",  # Blocked on content (indirectly via autofill).
       "//components/power",  # Blocked on content.
-      "//components/policy",  # Blocked on content (indirectly via autofill).
       "//components/precache/content",  # Blocked on content.
       "//components/precache/core",  # Should work, needs checking.
       "//components/rappor",  # Should work, needs checking.
       "//components/renderer_context_menu",  # Blocked on content.
       "//components/search_engines",  # Should work, needs checking.
       "//components/search_provider_logos",  # Should work, needs checking.
       "//components/sessions",  # Blocked on content.
       "//components/signin/core/browser",  # Should work, needs checking.
       "//components/translate/content/browser",  # Blocked on content.
       "//components/translate/content/common",  # Blocked on content.
       "//components/translate/content/renderer",  # Blocked on content.
       "//components/user_prefs",  # Blocked on content.
       "//components/visitedlink/browser",  # Blocked on content.
       "//components/visitedlink/common",  # Blocked on content.
       "//components/visitedlink/renderer",  # Blocked on blink
       "//components/web_cache/browser",  # Blocked on content and blink.
       "//components/web_cache/renderer",  # Blocked on content and blink.
+      "//components/web_modal",  # Blocked on content.
       "//components/webdata_services",  # Should work, needs checking.
-      "//components/web_modal",  # Blocked on content.
     ]
   }
 }
 
 # TODO(GYP): Delete this after we've converted everything to GN.
 # The _run targets exist only for compatibility w/ GYP.
 group("components_unittests_run") {
   testonly = true
   deps = [
     ":components_unittests",
@@ skipping 37 matching lines @@
     "//components/dom_distiller/core:unit_tests",
     "//components/enhanced_bookmarks:unit_tests",
     "//components/favicon/core:unit_tests",
     "//components/favicon_base:unit_tests",
     "//components/gcm_driver:unit_tests",
     "//components/google/core/browser:unit_tests",
     "//components/history/core/browser:unit_tests",
     "//components/history/core/common:unit_tests",
     "//components/invalidation/impl:unit_tests",
     "//components/keyed_service/core:unit_tests",
+    "//components/leveldb_proto:unit_tests",
     "//components/metrics:unit_tests",
     "//components/net_log:unit_tests",
     "//components/network_time:unit_tests",
+    "//components/omnibox/browser:unit_tests",
     "//components/open_from_clipboard:unit_tests",
+    "//components/os_crypt:unit_tests",
     "//components/password_manager/core/browser:unit_tests",
     "//components/password_manager/core/common:unit_tests",
     "//components/password_manager/sync/browser:unit_tests",
     "//components/proxy_config:unit_tests",
     "//components/rappor:unit_tests",
     "//components/search:unit_tests",
+    "//components/search_engines:unit_tests",
     "//components/sessions:unit_tests",
+    "//components/signin/core/browser:unit_tests",
+    "//components/suggestions:unit_tests",
+    "//components/sync_driver:unit_tests",
     "//components/syncable_prefs:unit_tests",
+    "//components/translate/core/browser:unit_tests",
+    "//components/translate/core/common:unit_tests",
+    "//components/translate/core/language_detection:unit_tests",
     "//components/undo:unit_tests",
     "//components/update_client:unit_tests",
     "//components/upload_list:unit_tests",
+    "//components/variations:unit_tests",
+    "//components/variations/service:unit_tests",
+    "//components/web_resource:unit_tests",
     "//net",
     "//ui/base",
     "//ui/resources:ui_test_pak",
-    "//components/search_engines:unit_tests",
-    "//components/leveldb_proto:unit_tests",
-    "//components/signin/core/browser:unit_tests",
-    "//components/suggestions:unit_tests",
-    "//components/sync_driver:unit_tests",
-    "//components/translate/core/browser:unit_tests",
-    "//components/translate/core/common:unit_tests",
-    "//components/translate/core/language_detection:unit_tests",
-    "//components/variations:unit_tests",
-    "//components/variations/service:unit_tests",
-    "//components/omnibox/browser:unit_tests",
-    "//components/os_crypt:unit_tests",
-    "//components/web_resource:unit_tests",
   ]
 
   if (!is_ios) {
     deps += [
-      "//components/certificate_transparency:unit_tests",
-      "//components/data_use_measurement/content:unit_tests",
-      "//components/error_page/renderer:unit_tests",
-      "//components/guest_view/browser:unit_tests",
-      "//components/navigation_interception:unit_tests",
-      "//components/network_hints/renderer:unit_tests",
-      "//components/page_load_metrics/browser:unit_tests",
-      "//components/page_load_metrics/renderer:unit_tests",
-      "//components/power:unit_tests",
-      "//components/safe_json:unit_tests",
-      "//components/scheduler:unit_tests",
-      "//components/test_runner:test_runner",
-      "//components/tracing:unit_tests",
-      "//components/ui/zoom:unit_tests",
-      "//components/visitedlink/test:unit_tests",
-      "//components/web_cache/browser:unit_tests",
       "//components/auto_login_parser:unit_tests",
       "//components/autofill/content/browser:unit_tests",
       "//components/autofill/content/renderer:unit_tests",
       "//components/bubble:unit_tests",
       "//components/captive_portal:unit_tests",
+      "//components/certificate_transparency:unit_tests",
       "//components/cloud_devices/common:unit_tests",
       "//components/component_updater:unit_tests",
       "//components/crx_file:unit_tests",
       "//components/data_reduction_proxy/content/browser:unit_tests",
       "//components/data_reduction_proxy/core/browser:unit_tests",
       "//components/data_reduction_proxy/core/common:unit_tests",
+      "//components/data_use_measurement/content:unit_tests",
       "//components/device_event_log:unit_tests",
       "//components/devtools_http_handler:unit_tests",
       "//components/dom_distiller/content:unit_tests",
       "//components/domain_reliability:unit_tests",
+      "//components/error_page/renderer:unit_tests",
       "//components/favicon/content:unit_tests",
       "//components/gcm_driver/crypto:unit_tests",
       "//components/gcm_driver/instance_id:unit_tests",
+      "//components/guest_view/browser:unit_tests",
       "//components/history/content/browser:unit_tests",
       "//components/json_schema:unit_tests",
       "//components/keyed_service/content:unit_tests",
       "//components/language_usage_metrics:unit_tests",
       "//components/login:unit_tests",
       "//components/memory_pressure:unit_tests",
       "//components/mime_util:unit_tests",
+      "//components/navigation_interception:unit_tests",
+      "//components/network_hints/renderer:unit_tests",
       "//components/offline_pages:unit_tests",
       "//components/packed_ct_ev_whitelist:unit_tests",
+      "//components/page_load_metrics/browser:unit_tests",
+      "//components/page_load_metrics/renderer:unit_tests",
       "//components/password_manager/content/browser:unit_tests",
+      "//components/power:unit_tests",
       "//components/precache/content:unit_tests",
       "//components/precache/core:unit_tests",
       "//components/query_parser:unit_tests",
       "//components/safe_browsing_db:unit_tests",
+      "//components/safe_json:unit_tests",
+      "//components/scheduler:unit_tests",
+      "//components/search:unit_tests",
       "//components/search_engines:unit_tests",
-      "//components/search:unit_tests",
       "//components/search_provider_logos:unit_tests",
       "//components/ssl_config:unit_tests",
       "//components/sync_bookmarks:unit_tests",
       "//components/sync_sessions:unit_tests",
+      "//components/test_runner:test_runner",
+      "//components/tracing:unit_tests",
+      "//components/ui/zoom:unit_tests",
       "//components/url_formatter:unit_tests",
       "//components/url_matcher:unit_tests",
       "//components/user_prefs/tracked:unit_tests",
+      "//components/visitedlink/test:unit_tests",
       "//components/wallpaper:unit_tests",
+      "//components/web_cache/browser:unit_tests",
       "//components/webcrypto:unit_tests",
       "//components/webdata/common:unit_tests",
 
       # These are the deps required by the code in this target.
       "//components/policy:policy_component",
       "//content/test:test_support",
     ]
 
     if (!is_android) {
       deps += [
@@ skipping 18 matching lines @@
     if (is_android) {
       isolate_file = "components_unittests.isolate"
 
       deps += [ "//content/public/android:content_java" ]
       deps -= [ "//components/gcm_driver/instance_id:unit_tests" ]
 
       apk_deps = [
         "//components/invalidation/impl:java",
         "//components/safe_json/android:safe_json_java",
         "//components/signin/core/browser/android:java",
+        "//components/variations:variations_jni_test_headers",
         "//components/variations/android:variations_java",
         "//content/public/android:content_java",
         "//ui/android:ui_java",
       ]
 
       if (enable_configuration_policy) {
         apk_deps += [ "//components/policy/android:policy_java" ]
       }
     }
     if (is_chromeos) {
@@ skipping 128 matching lines @@
       "//third_party/dom_distiller_js/dist/test/data/",
     ]
   }
 
   if (is_mac) {
     data += [ "$root_out_dir/Content Shell.app/" ]
   }
 
   defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
   deps = [
-    "strings",
     "//base",
     "//base/test:test_support",
     "//testing/gmock",
     "//testing/gtest",
+    "strings",
   ]
   if (!is_ios) {
     deps += [
+      "//components/tracing",
+      "//content/test:browsertest_support",
+      "//content/test:test_support",
+      "//device/bluetooth",
+      "//ui/base",
       "autofill/content/browser",
       "autofill/content/renderer",
       "content_settings/core/common",
       "dom_distiller/content:content_browser",
       "dom_distiller/core",
       "dom_distiller/core:test_support",
       "password_manager/content/browser",
       "password_manager/content/common",
       "password_manager/content/renderer",
-      "//components/tracing",
-      "//content/test:browsertest_support",
-      "//content/test:test_support",
-      "//device/bluetooth",
-      "//ui/base",
     ]
 
     data_deps = [
       ":components_tests_pak",
       "//third_party/mesa:osmesa",
     ]
   }
   if (is_android) {
     sources += [ "test/android/browsertests_apk/components_browser_tests_jni_onload.cc" ]
     sources -= [ "autofill/content/browser/risk/fingerprint_browsertest.cc" ]
     deps += [ "//testing/android/native_test:native_test_support" ]
     use_default_launcher = false
     isolate_file = "components_browsertests.isolate"
     android_manifest =
         "${target_gen_dir}/components_browsertests_manifest/AndroidManifest.xml"
     apk_deps = [
       ":components_browsertests_assets",
       ":components_browsertests_java",
       ":components_browsertests_manifest",
     ]
   }
 
   if (is_linux) {
     # content_extractor_browsertest is a standalone content extraction tool built as
     # a MANUAL component_browsertest.
     sources += [ "dom_distiller/standalone/content_extractor_browsertest.cc" ]
     deps += [
+      "//base:prefs_test_support",
       "pref_registry:test_support",
-      "//base:prefs_test_support",
     ]
   }
 
   if (enable_basic_printing || enable_print_preview) {
     sources += [ "printing/test/print_web_view_helper_browsertest.cc" ]
     deps += [ "//components/printing/test:test_support" ]
   }
 }
 
 test("components_perftests") {
   sources = [
     "scheduler/base/task_queue_manager_delegate_for_test.cc",
     "scheduler/base/task_queue_manager_delegate_for_test.h",
     "scheduler/base/task_queue_manager_perftest.cc",
     "visitedlink/test/visitedlink_perftest.cc",
   ]
 
   # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 
   deps = [
     "//testing/gtest",
     "//testing/perf",
   ]
   if (!is_ios) {
     deps += [
       "//base",
       "//base/test:test_support_perf",
+      "//components/visitedlink/browser",
       "//content/test:test_support",
-      "//components/visitedlink/browser",
     ]
   }
 }