Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: runtime/bin/dartutils.h

Issue 1462953002: VM: Make more globals constant where easily possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Remove unnecessary const_cast Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/bin/dartutils.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef BIN_DARTUTILS_H_ 5 #ifndef BIN_DARTUTILS_H_
6 #define BIN_DARTUTILS_H_ 6 #define BIN_DARTUTILS_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "include/dart_native_api.h" 9 #include "include/dart_native_api.h"
10 10
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 static const uint8_t* SniffForMagicNumber(const uint8_t* text_buffer, 209 static const uint8_t* SniffForMagicNumber(const uint8_t* text_buffer,
210 intptr_t* buffer_len, 210 intptr_t* buffer_len,
211 bool* is_snapshot); 211 bool* is_snapshot);
212 212
213 // Write a magic number to indicate a script snapshot file. 213 // Write a magic number to indicate a script snapshot file.
214 static void WriteMagicNumber(File* file); 214 static void WriteMagicNumber(File* file);
215 215
216 // Global state that stores the original working directory.. 216 // Global state that stores the original working directory..
217 static const char* original_working_directory; 217 static const char* original_working_directory;
218 218
219 static const char* kDartScheme; 219 static const char* const kDartScheme;
220 static const char* kDartExtensionScheme; 220 static const char* const kDartExtensionScheme;
221 static const char* kAsyncLibURL; 221 static const char* const kAsyncLibURL;
222 static const char* kBuiltinLibURL; 222 static const char* const kBuiltinLibURL;
223 static const char* kCoreLibURL; 223 static const char* const kCoreLibURL;
224 static const char* kInternalLibURL; 224 static const char* const kInternalLibURL;
225 static const char* kIsolateLibURL; 225 static const char* const kIsolateLibURL;
226 static const char* kIOLibURL; 226 static const char* const kIOLibURL;
227 static const char* kIOLibPatchURL; 227 static const char* const kIOLibPatchURL;
228 static const char* kUriLibURL; 228 static const char* const kUriLibURL;
229 static const char* kHttpScheme; 229 static const char* const kHttpScheme;
230 static const char* kVMServiceLibURL; 230 static const char* const kVMServiceLibURL;
231 231
232 static uint8_t magic_number[]; 232 static const uint8_t magic_number[];
233 233
234 private: 234 private:
235 DISALLOW_ALLOCATION(); 235 DISALLOW_ALLOCATION();
236 DISALLOW_IMPLICIT_CONSTRUCTORS(DartUtils); 236 DISALLOW_IMPLICIT_CONSTRUCTORS(DartUtils);
237 }; 237 };
238 238
239 239
240 class CObject { 240 class CObject {
241 public: 241 public:
242 // These match the constants in sdk/lib/io/common.dart. 242 // These match the constants in sdk/lib/io/common.dart.
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 586
587 ~ScopedBlockingCall() { 587 ~ScopedBlockingCall() {
588 Dart_ThreadEnableProfiling(); 588 Dart_ThreadEnableProfiling();
589 } 589 }
590 }; 590 };
591 591
592 } // namespace bin 592 } // namespace bin
593 } // namespace dart 593 } // namespace dart
594 594
595 #endif // BIN_DARTUTILS_H_ 595 #endif // BIN_DARTUTILS_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/dartutils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698