Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1462923004: Reduce diffs with master in core (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Reduce diffs with master in core This week's version. Mostly whitespace, but takes the master version of core/src/fxge/ge/fx_ge_text.cpp verbatim. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7386e293a2b67794e6af02d0b71020a4bc987ce0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -12 lines) Patch
M core/include/fpdfapi/fpdf_render.h View 1 chunk +5 lines, -4 lines 0 comments Download
M core/include/fxcrt/fx_ext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M core/src/fpdftext/text_int.h View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 4 chunks +30 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, for review.
5 years, 1 month ago (2015-11-19 22:09:16 UTC) #1
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-20 01:50:30 UTC) #2
Tom Sepez
5 years, 1 month ago (2015-11-20 17:35:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7386e293a2b67794e6af02d0b71020a4bc987ce0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698