Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1462923002: PushMessagingNotificationManager: utility function to get StoragePartition. (Closed)

Created:
5 years, 1 month ago by Michael van Ouwerkerk
Modified:
5 years, 1 month ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mvanouwerkerk+watch_chromium.org, johnme+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PushMessagingNotificationManager: utility function to get StoragePartition. BUG=558402 Committed: https://crrev.com/2a285c5e5d6c09b6c38a544b558622c474790b05 Cr-Commit-Position: refs/heads/master@{#360619}

Patch Set 1 #

Patch Set 2 : Rename to GetStoragePartition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chrome/browser/push_messaging/push_messaging_notification_manager.cc View 1 5 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
5 years, 1 month ago (2015-11-19 15:41:04 UTC) #2
Peter Beverloo
nit: maybe name it GetStoragePartition? lgtm
5 years, 1 month ago (2015-11-19 15:43:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462923002/20001
5 years, 1 month ago (2015-11-19 16:35:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/98389)
5 years, 1 month ago (2015-11-19 16:53:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462923002/20001
5 years, 1 month ago (2015-11-19 17:03:49 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 17:48:39 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:49:15 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2a285c5e5d6c09b6c38a544b558622c474790b05
Cr-Commit-Position: refs/heads/master@{#360619}

Powered by Google App Engine
This is Rietveld 408576698