Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14629025: Create MetroViewerProcessHost as a common base for TestMetroViewerProcessHost and ChromeMetroViewer… (Closed)

Created:
7 years, 7 months ago by gab
Modified:
7 years, 7 months ago
Reviewers:
robertshield, sky, M-A Ruel
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Create MetroViewerProcessHost as a common base for TestMetroViewerProcessHost and ChromeMetroViewerProcessHost Bringing LaunchViewerAndWaitForConnection() to the common base so that ChromeMetroViewerProcessHost can also benefit from it (required for ash browser tests). BUG=179830 1st Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201806 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=201966 R=robertshield@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202113

Patch Set 1 #

Total comments: 12

Patch Set 2 : rebase on https://codereview.chromium.org/14576015/ #

Patch Set 3 : review #

Patch Set 4 : review + fix DEPS #

Patch Set 5 : merge in https://codereview.chromium.org/14576015/ #

Patch Set 6 : merge up to r201426 #

Patch Set 7 : make ChromeMetroViewerProcessHost an _aurawin file and fixup gyp #

Patch Set 8 : rebase on top of revert @r202073 #

Patch Set 9 : fix ash_unittests on win8 #

Patch Set 10 : merge before dcommit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -337 lines) Patch
M ash/ash.gyp View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M ash/test/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ash/test/ash_test_base.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +8 lines, -1 line 0 comments Download
M ash/test/test_metro_viewer_process_host.h View 1 chunk +7 lines, -51 lines 0 comments Download
M ash/test/test_metro_viewer_process_host.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -70 lines 0 comments Download
M chrome/browser/DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_process_platform_part_aurawin.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_platform_part_aurawin.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download
A + chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 2 3 4 5 6 4 chunks +10 lines, -38 lines 0 comments Download
D chrome/browser/metro_viewer/metro_viewer_process_host_win.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/metro_viewer/metro_viewer_process_host_win.cc View 1 1 chunk +0 lines, -114 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -5 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/metro_viewer/metro_viewer.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M win8/metro_driver/metro_driver.gyp View 1 chunk +1 line, -1 line 0 comments Download
A win8/viewer/metro_viewer_process_host.h View 1 2 3 4 5 6 7 8 1 chunk +94 lines, -0 lines 0 comments Download
A win8/viewer/metro_viewer_process_host.cc View 1 2 3 1 chunk +108 lines, -0 lines 0 comments Download
M win8/win8.gyp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
gab
Sir, PTAL. For now I'm getting a DEPS error when including from chrome/ to win8/. ...
7 years, 7 months ago (2013-05-15 18:56:58 UTC) #1
robertshield
https://codereview.chromium.org/14629025/diff/1/chrome/browser/metro_viewer/chrome_metro_viewer_process_host_win.h File chrome/browser/metro_viewer/chrome_metro_viewer_process_host_win.h (right): https://codereview.chromium.org/14629025/diff/1/chrome/browser/metro_viewer/chrome_metro_viewer_process_host_win.h#newcode5 chrome/browser/metro_viewer/chrome_metro_viewer_process_host_win.h:5: #ifndef CHROME_BROWSER_CHROME_METRO_VIEWER_METRO_VIEWER_PROCESS_HOST_WIN_H_ CHROME_BROWSER_CHROME_METRO_VIEWER_METRO_VIEWER_PROCESS_HOST_WIN_H_ -> CHROME_BROWSER_METRO_VIEWER_CHROME_METRO_VIEWER_PROCESS_HOST_WIN_H_ https://codereview.chromium.org/14629025/diff/1/win8/viewer/metro_viewer_process_host.cc File win8/viewer/metro_viewer_process_host.cc (right): ...
7 years, 7 months ago (2013-05-15 21:17:18 UTC) #2
gab
Comments addressed, but the meta question remains; where should MetroViewerProcessHost actually go? As it is ...
7 years, 7 months ago (2013-05-21 15:08:12 UTC) #3
robertshield
My suggestion is that the metro viewer process host stuff lives in /win8 and that ...
7 years, 7 months ago (2013-05-21 15:15:16 UTC) #4
gab
Done and fixed DEPS (or should a DEPS file be created even deeper than chrome/browser ...
7 years, 7 months ago (2013-05-21 15:23:27 UTC) #5
robertshield
lgtm
7 years, 7 months ago (2013-05-21 17:40:43 UTC) #6
gab
Scott, PTAL. Thanks, Gab
7 years, 7 months ago (2013-05-21 17:43:12 UTC) #7
sky
LGTM
7 years, 7 months ago (2013-05-21 17:48:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14629025/23001
7 years, 7 months ago (2013-05-22 11:27:38 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=26812
7 years, 7 months ago (2013-05-22 11:43:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14629025/23001
7 years, 7 months ago (2013-05-22 12:54:40 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, ...
7 years, 7 months ago (2013-05-22 13:07:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14629025/23001
7 years, 7 months ago (2013-05-22 13:55:45 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) aura_unittests, browser_tests, compositor_unittests, content_browsertests, content_unittests, interactive_ui_tests, ...
7 years, 7 months ago (2013-05-22 14:07:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14629025/23001
7 years, 7 months ago (2013-05-22 14:22:04 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=26834
7 years, 7 months ago (2013-05-22 14:35:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14629025/23001
7 years, 7 months ago (2013-05-22 16:22:50 UTC) #17
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=26851
7 years, 7 months ago (2013-05-22 16:35:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14629025/58001
7 years, 7 months ago (2013-05-22 17:28:58 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=117084
7 years, 7 months ago (2013-05-22 18:20:42 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14629025/58001
7 years, 7 months ago (2013-05-22 18:23:08 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14629025/58001
7 years, 7 months ago (2013-05-23 13:46:49 UTC) #22
commit-bot: I haz the power
Change committed as 201806
7 years, 7 months ago (2013-05-23 15:41:06 UTC) #23
gab
This was reverted, I had accidently removed the initializer of a bool to false in ...
7 years, 7 months ago (2013-05-24 15:27:18 UTC) #24
gab
7 years, 7 months ago (2013-05-24 16:55:40 UTC) #25
Message was sent while issue was closed. 
Committed patchset #10 manually as r202113 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698