Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 1462843002: Try to remove <algorithm> header from scoped_ptr.h, again. (Closed)

Created:
5 years, 1 month ago by dcheng
Modified:
5 years, 1 month ago
Reviewers:
danakj, jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to remove <algorithm> header from scoped_ptr.h, again. Hopefully this is really the last one... unfortunately, several waterfall configurations lack trybot coverage, and practical experience has shown that it's possible for new regressions to be introduced in the time taken to build the different configs on the waterfall. BUG=none R=danakj TBR=jrummell Committed: https://crrev.com/612012350e6a5e54ec972fecaa8edfdaa66ee103 Cr-Commit-Position: refs/heads/master@{#360632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M base/memory/scoped_ptr.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/formats/mp2t/ts_section_psi.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462843002/1
5 years, 1 month ago (2015-11-19 09:20:26 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 10:41:46 UTC) #4
dcheng
+danakj as a //base OWNER, +jrummell as a //media OWNER
5 years, 1 month ago (2015-11-19 16:21:08 UTC) #6
dcheng
FWIW, I have a successful Official build, so hopefully this will land successfully?
5 years, 1 month ago (2015-11-19 16:21:34 UTC) #7
danakj
LGTM if it works!
5 years, 1 month ago (2015-11-19 18:25:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462843002/1
5 years, 1 month ago (2015-11-19 18:26:46 UTC) #11
dcheng
TBRing jrummell and hoping nothing broke (again) in the last ten hours
5 years, 1 month ago (2015-11-19 18:27:06 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 18:37:14 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 18:37:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/612012350e6a5e54ec972fecaa8edfdaa66ee103
Cr-Commit-Position: refs/heads/master@{#360632}

Powered by Google App Engine
This is Rietveld 408576698