Apps: Grant sufficient permissions to the filesystem opened by fileSystem API

Apps: Grant sufficient permissions to the filesystem opened by fileSystem API

A fileSystem opened by chrome.fileSystem API is passable to a pepper plugin[1],
but currently we cannot open any files with CREATE/TRUNCATE flag under the
filesystem in plugin-side because the filesystem doesn't have sufficient file
permissions (CREATE_OVERWRITE_FILE_PERMISSION is missing).

To fix that, this change calls GrantCreateReadWriteFileSystem() for the
filesystem instead of GrantCreateFileForFileSystem().

(NOTE) This change works fine only when choosing a directory by the API, and
the same issue still happens when choosing a file. I'll address the case in
a separate CL.

[1] http://crbug.com/177017


BUG=336160
TEST=manual (open a file with CREATE and/or TRUNCATE flag under the passed filesystem in plugin)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247596

[nhiroki, 2014-01-27 10:22:42]

Hi,

benwells@, can you review this as an owner?
tsepez@, can you review this from a security viewpoint?

Thanks,
nhiroki

[Tom Sepez, 2014-01-27 19:37:52]

This should be OK since it applies only to Apps, right?

[nhiroki, 2014-01-28 01:45:54]

Updated (clean-up only).

On 2014/01/27 19:37:52, Tom Sepez wrote:
> This should be OK since it applies only to Apps, right?

Right. This should affect only apps which have 'write' permission in its
manifest file.

[benwells, 2014-01-28 07:05:20]

Replacing myself with Sam who knows this code better than I do now.

[Sam McNally, 2014-01-28 07:32:38]

lgtm

[Tom Sepez, 2014-01-28 18:11:30]

lgtm

[commit-bot: I haz the power, 2014-01-29 00:01:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/146283002/140001

[commit-bot: I haz the power, 2014-01-29 00:50:49]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 01:18:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/146283002/140001

[commit-bot: I haz the power, 2014-01-29 02:28:17]

Change committed as 247596