Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1462813003: Split BrowsingHistoryHandler out of history_ui.cc (Closed)

Created:
5 years, 1 month ago by tsergeant
Modified:
5 years, 1 month ago
Reviewers:
Dan Beam
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split BrowsingHistoryHandler out of history_ui.cc This cleans up history_ui.cc in preparation for adding a new WebUI for Material design history. BUG=425625 Committed: https://crrev.com/31dca18fdd6871a32e2a6c119b52020347be5941 Cr-Commit-Position: refs/heads/master@{#361060}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1432 lines) Patch
A + chrome/browser/ui/webui/browsing_history_handler.h View 1 4 chunks +9 lines, -18 lines 0 comments Download
A + chrome/browser/ui/webui/browsing_history_handler.cc View 1 10 chunks +15 lines, -194 lines 0 comments Download
A + chrome/browser/ui/webui/browsing_history_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.h View 1 chunk +2 lines, -207 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 3 chunks +2 lines, -880 lines 0 comments Download
D chrome/browser/ui/webui/history_ui_unittest.cc View 1 chunk +0 lines, -130 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
tsergeant
As discussed!
5 years, 1 month ago (2015-11-20 04:06:07 UTC) #2
Dan Beam
kinda rubbery lgtm (I assume you're mainly moving + shuffling includes correctly) https://codereview.chromium.org/1462813003/diff/1/chrome/browser/ui/webui/browsing_history_handler.cc File chrome/browser/ui/webui/browsing_history_handler.cc ...
5 years, 1 month ago (2015-11-20 20:13:00 UTC) #3
tsergeant
Thanks! https://codereview.chromium.org/1462813003/diff/1/chrome/browser/ui/webui/browsing_history_handler.cc File chrome/browser/ui/webui/browsing_history_handler.cc (right): https://codereview.chromium.org/1462813003/diff/1/chrome/browser/ui/webui/browsing_history_handler.cc#newcode88 chrome/browser/ui/webui/browsing_history_handler.cc:88: base::string16 getRelativeDateLocalized(const base::Time& visit_time) { On 2015/11/20 at ...
5 years, 1 month ago (2015-11-22 23:45:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462813003/20001
5 years, 1 month ago (2015-11-22 23:45:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 00:26:40 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 00:27:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31dca18fdd6871a32e2a6c119b52020347be5941
Cr-Commit-Position: refs/heads/master@{#361060}

Powered by Google App Engine
This is Rietveld 408576698