Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
diff --git a/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp b/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
index 8c82673239abdaf3a541ab179952b4cdadfc83fb..329fbe22e985abbcef8168a919f1b1a16887c1a8 100644
--- a/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
+++ b/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
@@ -45,7 +45,7 @@ PassRefPtr<MediaStreamAudioDestinationNode> MediaStreamAudioDestinationNode::cre
MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode(AudioContext* context, size_t numberOfChannels)
: AudioBasicInspectorNode(context, context->sampleRate(), numberOfChannels)
- , m_mixBus(numberOfChannels, ProcessingSizeInFrames)
+ , m_mixBus(new AudioBus(numberOfChannels, ProcessingSizeInFrames))
Chris Rogers 2013/05/02 17:48:46 adoptRef()
{
setNodeType(NodeTypeMediaStreamAudioDestination);
@@ -73,8 +73,8 @@ MediaStreamAudioDestinationNode::~MediaStreamAudioDestinationNode()
void MediaStreamAudioDestinationNode::process(size_t numberOfFrames)
{
- m_mixBus.copyFrom(*input(0)->bus());
- m_source->consumeAudio(&m_mixBus, numberOfFrames);
+ m_mixBus->copyFrom(*input(0)->bus());
+ m_source->consumeAudio(m_mixBus.get(), numberOfFrames);
}
void MediaStreamAudioDestinationNode::reset()

Powered by Google App Engine
This is Rietveld 408576698