Source/core/platform/audio/AudioPullFIFO.h - Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/audio/AudioPullFIFO.h

Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/platform/audio/AudioFIFO.cpp ('K') | « Source/core/platform/audio/AudioFIFO.cpp ('k') | Source/core/platform/audio/AudioPullFIFO.cpp » ('j') | Source/core/platform/audio/AudioPullFIFO.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/audio/AudioPullFIFO.h

diff --git a/Source/core/platform/audio/AudioPullFIFO.h b/Source/core/platform/audio/AudioPullFIFO.h

index c507cea6933c7f40f037fd4f1538288f21e8bfb3..86795a180439b60086d067892c7635dc7a6934bf 100644

--- a/Source/core/platform/audio/AudioPullFIFO.h

+++ b/Source/core/platform/audio/AudioPullFIFO.h

@@ -66,7 +66,7 @@ private:

unsigned int m_providerSize;

// Temporary workspace to hold the data from the provider.

- AudioBus m_tempBus;

+ RefPtr<AudioBus> m_tempBus;

};

} // namespace WebCore