Source/core/platform/audio/AudioPullFIFO.h - Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/platform/audio/AudioPullFIFO.h

Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/platform/audio/AudioFIFO.cpp ('K') | « Source/core/platform/audio/AudioFIFO.cpp ('k') | Source/core/platform/audio/AudioPullFIFO.cpp » ('j') | Source/core/platform/audio/AudioPullFIFO.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 // The provider of the data in our FIFO.	59 // The provider of the data in our FIFO.

60 AudioSourceProvider& m_provider;	60 AudioSourceProvider& m_provider;

61	61

62 // The actual FIFO	62 // The actual FIFO

63 AudioFIFO m_fifo;	63 AudioFIFO m_fifo;

64	64

65 // Number of frames of data that the provider will produce per call.	65 // Number of frames of data that the provider will produce per call.

66 unsigned int m_providerSize;	66 unsigned int m_providerSize;

67	67

68 // Temporary workspace to hold the data from the provider.	68 // Temporary workspace to hold the data from the provider.

69 AudioBus m_tempBus;	69 RefPtr<AudioBus> m_tempBus;

70 };	70 };

71	71

72 } // namespace WebCore	72 } // namespace WebCore

73	73

74 #endif // AudioPullFIFO.h	74 #endif // AudioPullFIFO.h

OLD	NEW