Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1462753002: Define MOJO_SHELL_CLIENT uniformly across content (Closed)

Created:
5 years, 1 month ago by Ben Goodger (Google)
Modified:
5 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define MOJO_SHELL_CLIENT uniformly across content Separated out of https://codereview.chromium.org/1452823003/ TBR=jam@chromium.org http://crbug.com/551253 Committed: https://crrev.com/5e739169f376c3bf9c2c35a4efa0ebb6cbb3a9ee Cr-Commit-Position: refs/heads/master@{#360514}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -11 lines) Patch
M content/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 chunks +4 lines, -3 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M content/plugin/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M content/ppapi_plugin/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M content/utility/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462753002/40001
5 years, 1 month ago (2015-11-19 02:45:57 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-19 03:35:29 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5e739169f376c3bf9c2c35a4efa0ebb6cbb3a9ee Cr-Commit-Position: refs/heads/master@{#360514}
5 years, 1 month ago (2015-11-19 03:37:08 UTC) #7
Ben Goodger (Google)
5 years, 1 month ago (2015-11-19 04:34:51 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1455423002/ by ben@chromium.org.

The reason for reverting is: Not needed..

Powered by Google App Engine
This is Rietveld 408576698