Re-implement form validation message UI with native widgets (Views)

chrome/browser/chrome_content_browser_client.cc

Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index c51859e0ced7e6fcf7517e0c66d60202763e3211..42aa6ab13fb3a3e25d65677891053a46f4f2c6d0 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -727,10 +727,7 @@ void ChromeContentBrowserClient::RenderProcessHostCreated(
       id, profile, context));
   host->GetChannel()->AddFilter(
       new prerender::PrerenderMessageFilter(id, profile));
-#if defined(OS_MACOSX)

[sky, 2013/04/30 13:53:21]

I don't see a gtk implementation. How is the linux side working?

[tkent, 2013/05/01 03:15:02]

GTK and Android implementations are not checked in and not in this CL.  I'm
going to post separated CLs.
Enabling ValidationMessageMessagesFilter here for all platforms has no problem
because we have a guard in validation_message_agent.cc and IPC messages are
never sent on GTK and Android.

[sky, 2013/05/01 04:35:53]

Don't you still need an ifdef then?

[tkent, 2013/05/01 04:50:12]

It's not needed.
We may keep the ifdef to avoid to register unnecessary ValidationMessageFilter
in GTK and Android.
Or, we may remove the ifdef to reduce patch sizes for incoming GTK and Android
patches. We can remove the ifdef because the messages are never sent in GTK and
Android.

-  // TODO(tkent): Enable it for other platforms.
   host->GetChannel()->AddFilter(new ValidationMessageMessageFilter(id));
-#endif
 
   host->Send(new ChromeViewMsg_SetIsIncognitoProcess(
       profile->IsOffTheRecord()));