Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: chrome/browser/ui/views/validation_message_bubble_delegate_unittest.cc

Issue 14627004: Re-implement form validation message UI with native widgets (Views) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/validation_message_bubble_delegate_unittest.cc
diff --git a/chrome/browser/ui/views/validation_message_bubble_delegate_unittest.cc b/chrome/browser/ui/views/validation_message_bubble_delegate_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7638ca93221c9e1582f83769af66ca4a0145cd1b
--- /dev/null
+++ b/chrome/browser/ui/views/validation_message_bubble_delegate_unittest.cc
@@ -0,0 +1,48 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/validation_message_bubble_delegate.h"
+
+#include "base/utf_string_conversions.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+gfx::Size GetSizeForMessages(const std::string& main_text,
+ const std::string& sub_text) {
+ ValidationMessageBubbleDelegate delegate(
+ gfx::Rect(), UTF8ToUTF16(main_text), UTF8ToUTF16(sub_text));
+ return delegate.GetPreferredSize();
+}
+
+TEST(ValidationMessageBubbleDelegate, Size) {
+ gfx::Size short_main_empty_sub_size = GetSizeForMessages("foo", "");
+ EXPECT_GE(short_main_empty_sub_size.width(), 64);
sky 2013/05/01 14:05:05 expect/assert have the format expected, actual.
tkent 2013/05/01 21:42:30 Done.
+ EXPECT_GT(short_main_empty_sub_size.height(), 0);
+
+ gfx::Size long_main_empty_sub_size = GetSizeForMessages(
+ "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod"
+ " tempor incididunt ut labore et dolore magna aliqua.", "");
+ EXPECT_LE(long_main_empty_sub_size.width(), 256);
+ EXPECT_GT(long_main_empty_sub_size.height(),
+ short_main_empty_sub_size.height());
+
+ gfx::Size short_main_medium_sub_size =
+ GetSizeForMessages("foo", "foo bar baz");
+ EXPECT_GT(short_main_medium_sub_size.width(),
+ short_main_empty_sub_size.width());
+ EXPECT_GT(short_main_medium_sub_size.height(),
+ short_main_empty_sub_size.height());
+
+ gfx::Size short_main_long_sub_size = GetSizeForMessages("foo",
+ "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod"
+ " tempor incididunt ut labore et dolore magna aliqua.");
+ EXPECT_GT(short_main_long_sub_size.width(),
+ short_main_medium_sub_size.width());
+ EXPECT_LE(short_main_long_sub_size.width(), 256);
+ EXPECT_GT(short_main_long_sub_size.height(),
+ short_main_medium_sub_size.height());
+}
+
+}

Powered by Google App Engine
This is Rietveld 408576698