Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1462613002: Move cc::LayerSettings to cc/layers/layer_settings.h. (Closed)

Created:
5 years, 1 month ago by jbroman
Modified:
5 years, 1 month ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move cc::LayerSettings to cc/layers/layer_settings.h. It's somewhat confusing to have to find it in cc/trees/layer_tree_settings.h. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=dtrainor@chromium.org,piman@chromium.org Committed: https://crrev.com/49fa12e81e620e6af4b411841a98518cc45f67f8 Cr-Commit-Position: refs/heads/master@{#360441}

Patch Set 1 #

Patch Set 2 : cc_unittests #

Patch Set 3 : misc changes #

Patch Set 4 : blimp and android #

Patch Set 5 : cc_perftests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -25 lines) Patch
M blimp/client/compositor/blimp_compositor.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/compositor/test/dummy_layer_driver.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/blink/web_layer_impl_fixed_bounds_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/debug/micro_benchmark_controller_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/delegated_frame_provider_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/delegated_renderer_layer_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer_perftest.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer_position_constraint_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer_proto_converter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer_proto_converter_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
A cc/layers/layer_settings.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + cc/layers/layer_settings.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/nine_patch_layer_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/picture_image_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/solid_color_layer_impl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/ui_resource_layer_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_host_common_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_json_parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/android/DEPS View 1 2 2 chunks +1 line, -1 line 0 comments Download
M ui/android/window_android_compositor.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jbroman
If this LGTY, I'll TBR some folks for the handful of call sites outside cc ...
5 years, 1 month ago (2015-11-18 22:02:22 UTC) #2
enne (OOO)
lgtm
5 years, 1 month ago (2015-11-18 22:05:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462613002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462613002/80001
5 years, 1 month ago (2015-11-18 22:11:15 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-18 23:17:22 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 23:19:08 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/49fa12e81e620e6af4b411841a98518cc45f67f8
Cr-Commit-Position: refs/heads/master@{#360441}

Powered by Google App Engine
This is Rietveld 408576698