src/isolate.cc - Issue 1462573002: Wait for cancelable task after tearing down the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 1462573002: Wait for cancelable task after tearing down the heap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 68a6745d56b57cf77d12fa789d2d6392adbba568..5bb2311efbec26b5fbb56df8a750aca90d1844f7 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -1921,11 +1921,11 @@ void Isolate::Deinit() {

delete basic_block_profiler_;

basic_block_profiler_ = NULL;

- cancelable_task_manager()->CancelAndWait();

heap_.TearDown();

logger_->TearDown();

+ cancelable_task_manager()->CancelAndWait();

delete heap_profiler_;

heap_profiler_ = NULL;

delete cpu_profiler_;

« no previous file with comments | « no previous file | no next file » | no next file with comments »