Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1462573002: Wait for cancelable task after tearing down the heap. (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Wait for cancelable task after tearing down the heap. BUG= Committed: https://crrev.com/eb8a42383c756858519d6c3c08be8e0898bee357 Cr-Commit-Position: refs/heads/master@{#32093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/isolate.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462573002/1
5 years, 1 month ago (2015-11-18 17:14:33 UTC) #2
payer
lgtm
5 years, 1 month ago (2015-11-18 17:16:07 UTC) #4
Hannes Payer (out of office)
lgtm
5 years, 1 month ago (2015-11-18 17:17:07 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 17:34:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462573002/1
5 years, 1 month ago (2015-11-18 17:35:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 17:36:59 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 17:37:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb8a42383c756858519d6c3c08be8e0898bee357
Cr-Commit-Position: refs/heads/master@{#32093}

Powered by Google App Engine
This is Rietveld 408576698