Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1462533002: Fix running standalone-precompiled when passing a package-root/-file/-map. (Closed)

Created:
5 years, 1 month ago by Florian Schneider
Modified:
5 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix running standalone-precompiled when passing a package-root/-file/-map. These are missing embedder entry points for standalone VM and are needed when e.g. passing --package-root to a precompiled snapshot. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/72bd5adf00910665def364f3a5bb47baa8fc2535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M runtime/bin/main.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 1 month ago (2015-11-18 16:23:10 UTC) #2
rmacnak
lgtm
5 years, 1 month ago (2015-11-18 17:43:45 UTC) #3
Florian Schneider
5 years, 1 month ago (2015-11-18 18:00:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72bd5adf00910665def364f3a5bb47baa8fc2535 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698