tools/cygprofile/symbol_extractor.py - Issue 1462503002: Mechanically change TODO(azarchs) into TODO(pasko)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cygprofile/symbol_extractor.py

Issue 1462503002: Mechanically change TODO(azarchs) into TODO(pasko) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add lizeb as well Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/cygprofile/symbol_extractor.py

diff --git a/tools/cygprofile/symbol_extractor.py b/tools/cygprofile/symbol_extractor.py

index a30c05ee3428840ef5f0d14a5cd33eb959e52c76..d7091170f5f8080f5e2d89af01de4a5227d7f9f1 100755

--- a/tools/cygprofile/symbol_extractor.py

+++ b/tools/cygprofile/symbol_extractor.py

@@ -137,7 +137,8 @@ def CreateNameToSymbolInfo(symbol_infos):

If a symbol name corresponds to more than one symbol_info, the symbol_info

with the lowest offset is chosen.

"""

- #TODO(azarchs): move the functionality in this method into check_orderfile.

+ # TODO(lizeb,pasko): move the functionality in this method into

+ # check_orderfile.

symbol_infos_by_name = {}

warnings = cygprofile_utils.WarningCollector(_MAX_WARNINGS_TO_PRINT)

for infos in GroupSymbolInfosByName(symbol_infos).itervalues():

« no previous file with comments | « tools/cygprofile/profile_android_startup.py ('k') | no next file » | no next file with comments »