Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/cygprofile/patch_orderfile.py

Issue 1462503002: Mechanically change TODO(azarchs) into TODO(pasko) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add lizeb as well Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/cygprofile/cygprofile_utils.py ('k') | tools/cygprofile/profile_android_startup.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cygprofile/patch_orderfile.py
diff --git a/tools/cygprofile/patch_orderfile.py b/tools/cygprofile/patch_orderfile.py
index 0092ddd6d1cd562a32b07a874a0435e801adfd1d..dbb344f174a8477912331551a7996df8ce025157 100755
--- a/tools/cygprofile/patch_orderfile.py
+++ b/tools/cygprofile/patch_orderfile.py
@@ -187,7 +187,7 @@ def GetSymbolsFromOrderfile(filename, section_to_symbols_map):
Yields:
A list of symbol names.
"""
- # TODO(azarchs): Move this method to symbol_extractor.py
+ # TODO(lizeb,pasko): Move this method to symbol_extractor.py
for section in GetSectionsFromOrderfile(filename):
for symbol in _SectionNameToSymbols(RemoveSuffixes(section),
section_to_symbols_map):
@@ -250,7 +250,7 @@ def _SectionMatchingRules(section_name, name_to_symbol_infos,
# suffixes, don't emit the wildcards for ones where it won't be helpful.
# Otherwise linking takes too long.
if name in suffixed_sections:
- # TODO(azarchs): instead of just appending .*, append .suffix.* for
+ # TODO(lizeb,pasko): instead of just appending .*, append .suffix.* for
# _SUFFIXES. We can't do this right now because that many wildcards
# seems to kill the linker (linking libchrome takes 3 hours). This gets
# almost all the benefit at a much lower link-time cost, but could cause
« no previous file with comments | « tools/cygprofile/cygprofile_utils.py ('k') | tools/cygprofile/profile_android_startup.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698