Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1462503002: Mechanically change TODO(azarchs) into TODO(pasko) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add lizeb as well Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/cygprofile/cygprofile.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/ccache.gni") 9 import("//build/toolchain/ccache.gni")
10 10
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 cflags += [ "-fno-stack-protector" ] 170 cflags += [ "-fno-stack-protector" ]
171 } else { 171 } else {
172 cflags += [ "-fstack-protector" ] 172 cflags += [ "-fstack-protector" ]
173 } 173 }
174 } 174 }
175 175
176 # Linker warnings. 176 # Linker warnings.
177 if (!(is_chromeos && current_cpu == "arm") && 177 if (!(is_chromeos && current_cpu == "arm") &&
178 !(is_android && use_order_profiling) && !is_mac && !is_ios) { 178 !(is_android && use_order_profiling) && !is_mac && !is_ios) {
179 # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580 179 # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580
180 # TODO(azarchs): Fix link errors when linking with order_profiling=1 180 # TODO(lizeb,pasko): Fix link errors when linking with order_profiling=1
181 # crbug.com/485542 181 # crbug.com/485542
182 ldflags += [ "-Wl,--fatal-warnings" ] 182 ldflags += [ "-Wl,--fatal-warnings" ]
183 } 183 }
184 } 184 }
185 185
186 if (is_clang && is_debug) { 186 if (is_clang && is_debug) {
187 # Allow comparing the address of references and 'this' against 0 187 # Allow comparing the address of references and 'this' against 0
188 # in debug builds. Technically, these can never be null in 188 # in debug builds. Technically, these can never be null in
189 # well-defined C/C++ and Clang can optimize such checks away in 189 # well-defined C/C++ and Clang can optimize such checks away in
190 # release builds, but they may be used in asserts in debug builds. 190 # release builds, but they may be used in asserts in debug builds.
(...skipping 1045 matching lines...) Expand 10 before | Expand all | Expand 10 after
1236 if (symbol_level == 0) { 1236 if (symbol_level == 0) {
1237 configs = [ ":no_symbols" ] 1237 configs = [ ":no_symbols" ]
1238 } else if (symbol_level == 1) { 1238 } else if (symbol_level == 1) {
1239 configs = [ ":minimal_symbols" ] 1239 configs = [ ":minimal_symbols" ]
1240 } else if (symbol_level == 2) { 1240 } else if (symbol_level == 2) {
1241 configs = [ ":symbols" ] 1241 configs = [ ":symbols" ]
1242 } else { 1242 } else {
1243 assert(false) 1243 assert(false)
1244 } 1244 }
1245 } 1245 }
OLDNEW
« no previous file with comments | « no previous file | tools/cygprofile/cygprofile.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698