Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: net/http/http_cache_transaction.h

Issue 14625012: net: Return LoadTiming information in the case of a cache hit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Missed a couple spots Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_cache_transaction.h
===================================================================
--- net/http/http_cache_transaction.h (revision 199488)
+++ net/http/http_cache_transaction.h (working copy)
@@ -24,6 +24,7 @@
class PartialData;
struct HttpRequestInfo;
class HttpTransactionDelegate;
+struct LoadTimingInfo;
// This is the transaction that is returned by the HttpCache transaction
// factory.
@@ -385,6 +386,10 @@
void RunDelayedLoop(base::TimeTicks delay_start_time,
base::TimeDelta intended_delay, int result);
+ // Resets |network_trans_|, which must be non-NULL. Also updates
+ // |old_network_trans_load_timing_|, which must NULL.
eroman 2013/05/15 01:11:50 "which must NULL" --> something is missing
mmenke 2013/05/15 01:52:38 Done.
+ void ResetNetworkTransaction();
+
State next_state_;
const HttpRequestInfo* request_;
RequestPriority priority_;
@@ -447,6 +452,11 @@
int sensitivity_analysis_percent_increase_;
HttpTransactionDelegate* transaction_delegate_;
+
+ // Load timing information for the last network request, if any. Set in the
+ // 304 and 206 response cases, as the network transaction may be destroyed
+ // before the caller requests load timing information.
+ scoped_ptr<LoadTimingInfo> old_network_trans_load_timing_;
};
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698